Make triecache generic and work for no-std environments #14403
Conversation
skunert
added
A0-please_review
Co-authored-by: Bastian Köcher <[email protected]>
|
bot fmt |
|
@skunert https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3028934 was started for your command Comment |
|
@skunert Command |
| } | ||
|
|
||
| /// Create new trie-based backend. | ||
| pub fn new_with_cache(storage: S, root: H::Out, cache: Option<C>) -> Self { |
There was a problem hiding this comment.
You could simplify TrieBackendEssence::new by calling this method in there. (Self::new_with_cache(storage, root, None) instead of having the whole struct initialized in two places)
There was a problem hiding this comment.
Also third copy below could be initialized with new.
Co-authored-by: Koute <[email protected]>
Co-authored-by: Michal Kucharczyk <[email protected]>
|
bot merge |
…4403) * Remove `AsLocalTrieCache` trait * Introduce new trait AsTrieDbCache * Use AsTrieDbCache trait * Make it compile * Docs * Improve naming of associated type, implement cache usage for no-std * Improve naming * Improve docs * Allow construction with optional cache * FMT * Remove unused variable * Revert unwanted change * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * More comment adjustments * Docs * Trigger CI * ".git/.scripts/commands/fmt/fmt.sh" * Apply suggestions from code review Co-authored-by: Koute <[email protected]> * Review comments * Review comments * Apply suggestions from code review Co-authored-by: Michal Kucharczyk <[email protected]> * fmt * Bump trie-db again --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Koute <[email protected]> Co-authored-by: Michal Kucharczyk <[email protected]>
This pull request refactors the trie-cache related traits and makes the system generic. Until now the caching system was bound to the
LocalTrieCacheimplementation. This is one step towards enabling theTrieCacheinvalidate_blockparitytech/cumulus#2432.This refactoring contains no behavioural changes for existing code.
Change summary:
MergeableTrieCacheProvider: This trait can be implemented to provide cache implementations to theTrieBackendAsLocalTrieCachetrait: No longer required since functionality is covered byMergeableTrieCacheProviderPolkadot companion: paritytech/polkadot#7435