This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Restructure frame_benchmarking macro related exports
#14787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot rebase |
…orts' into jg/restructure-benchmarking-macro-related-exports
|
Rebased |
Base automatically changed from
jg/restructure-macro-related-exports
to
master
August 23, 2023 12:30
paritytech-processbot
bot
requested review from
athei,
acatangiu,
cheme and
jsidorenko
as code owners
ggwpez
approved these changes
Aug 23, 2023
liamaharon
reviewed
Aug 24, 2023
Comment on lines
+58
to
+60
| help: consider importing one of these items | ||
| | | ||
| 1 + use frame_benchmarking::__private::traits::PalletInfo; |
There was a problem hiding this comment.
Shouldn't this suggest
Suggested change
| help: consider importing one of these items | |
| | | |
| 1 + use frame_benchmarking::__private::traits::PalletInfo; | |
| help: consider importing one of these items | |
| | | |
| 1 + use frame_support::traits::PalletInfo; |
There was a problem hiding this comment.
Interesting, do you know if it is possible to somehow tell the compiler to ignore that option?
bkchr
reviewed
Aug 24, 2023
| @@ -1,6 +1,7 @@ | |||
| //! Benchmarking setup for pallet-template | |||
| #![cfg(feature = "runtime-benchmarks")] | |||
| use super::*; | |||
| use sp_std::vec; | |||
There was a problem hiding this comment.
This looks wrong? I don't see any usage of the macro in here. Maybe some macro needs this? If yes, it should pull this in automatically.
There was a problem hiding this comment.
It is expected here https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3434676
[2023-08-24 12:21:48] error: cannot find macro `vec` in this scope
[2023-08-24 12:21:48] --> /builds/parity/mirrors/substrate/bin/node-template/pallets/template/src/benchmarking.rs:10:1
[2023-08-24 12:21:48] |
[2023-08-24 12:21:48] 10 | #[benchmarks]
[2023-08-24 12:21:48] | ^^^^^^^^^^^^^
[2023-08-24 12:21:48] |
[2023-08-24 12:21:48] = help: consider importing one of these items:
[2023-08-24 12:21:48] crate::benchmarking::__private::vec
[2023-08-24 12:21:48] frame_benchmarking::__private::vec
[2023-08-24 12:21:48] scale_info::prelude::vec
[2023-08-24 12:21:48] sp_std::vec
[2023-08-24 12:21:48] = note: this error originates in the attribute macro `benchmarks` (in Nightly builds, run with -Z macro-backtrace for more info)
| use crate::benchmarks; | ||
| use frame_system::Pallet as System; | ||
| use sp_runtime::{ | ||
| traits::{AppVerify, Hash}, | ||
| RuntimeAppPublic, | ||
| }; | ||
| use sp_std::{vec, vec::Vec}; |
There was a problem hiding this comment.
It is actually required https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3434492
[2023-08-24 12:02:10] error: cannot find macro `vec` in this scope
[2023-08-24 12:02:10] --> /builds/parity/mirrors/substrate/frame/benchmarking/src/baseline.rs:93:14
[2023-08-24 12:02:10] |
[2023-08-24 12:02:10] 93 | let msg = vec![j, j];
[2023-08-24 12:02:10] | ^^^
[2023-08-24 12:02:10] |
[2023-08-24 12:02:10] = help: consider importing one of these items:
[2023-08-24 12:02:10] crate::__private::vec
[2023-08-24 12:02:10] scale_info::prelude::vec
[2023-08-24 12:02:10] sp_api::vec
[2023-08-24 12:02:10] sp_std::vec
[2023-08-24 12:02:10]
[2023-08-24 12:02:10] error[E0412]: cannot find type `Vec` in this scope
[2023-08-24 12:02:10] --> /builds/parity/mirrors/substrate/frame/benchmarking/src/baseline.rs:92:21
[2023-08-24 12:02:10] |
[2023-08-24 12:02:10] 92 | let msg_and_sigs: Vec<_> = (0..sigs_count).map(|j| {
[2023-08-24 12:02:10] | ^^^ not found in this scope
[2023-08-24 12:02:10] |
[2023-08-24 12:02:10] help: consider importing one of these items
[2023-08-24 12:02:10] |
[2023-08-24 12:02:10] 23 + use crate::__private::Vec;
[2023-08-24 12:02:10] |
[2023-08-24 12:02:10] 23 + use frame_support::dispatch::Vec;
[2023-08-24 12:02:10] |
[2023-08-24 12:02:10] 23 + use scale_info::prelude::vec::Vec;
[2023-08-24 12:02:10] |
[2023-08-24 12:02:10] 23 + use sp_api::vec::Vec;
[2023-08-24 12:02:10] |
[2023-08-24 12:02:10] and 2 other candidates
liamaharon
approved these changes
Aug 24, 2023
|
bot merge |
paritytech-processbot
bot
deleted the
jg/restructure-benchmarking-macro-related-exports
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for paritytech/polkadot-sdk#172