This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update to x25519-dalek v2.0.0
#14797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
added
A0-please_review
|
Duplicate of: #14776 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
x25519-dalekdependency.Substrate master CI is red since this
cargo buildline here pulls in version 2.0.0 instead of the pre-release, which makes the build fail.substrate/scripts/ci/node-template-release/src/main.rs
Line 237 in aeb8c31
I will try to see if it makes sense to copy the Substrate Cargo.lock into the template release build, such that it wont blindly update deps when building.
-> Does not work since the lockfile of Substrate needs to be updated to remove the unused deps, but
--lockedwould prevent that...