Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[NFTs] Make owned_item in MintWitness optional #14800

Merged
merged 2 commits into from
Aug 21, 2023
Merged

[NFTs] Make owned_item in MintWitness optional #14800

merged 2 commits into from
Aug 21, 2023

Conversation

jsidorenko
Copy link
Contributor

In the MintWitness object, all the fields are supposed to be optional.
We validate them depending on the collection settings: MintWitness.owned_item when the mint_type = HolderOf and MintWitness.mint_price when the mint price is set.

@jsidorenko jsidorenko added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 21, 2023
@jsidorenko jsidorenko requested a review from a team August 21, 2023 12:23
@jsidorenko
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@jsidorenko
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit e526f80 into master Aug 21, 2023
4 checks passed
@paritytech-processbot paritytech-processbot bot deleted the js/make-owned_item-optional branch August 21, 2023 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gilescope gilescope gilescope approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsidorenko @gilescope @ggwpez