Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for PFQuery.containedBy #1735

Merged
merged 2 commits into from
Jul 20, 2023
Merged

feat: Add support for PFQuery.containedBy #1735

merged 2 commits into from
Jul 20, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 14, 2023

New Pull Request Checklist

Issue Description

Adds PFQuery and LiveQuery support for $containedBy query

Ref: parse-community/parse-server#4766
Closes: n/a

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 14, 2023 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (bd09fe4) 78.20% compared to head (d05971f) 78.22%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1735      +/-   ##
==========================================
+ Coverage   78.20%   78.22%   +0.02%     
==========================================
  Files         307      307              
  Lines       36936    36981      +45     
==========================================
+ Hits        28884    28929      +45     
  Misses       8052     8052
Impacted Files Coverage Δ
...lDataStore/OfflineQueryLogic/PFOfflineQueryLogic.m 63.27% <100.00%> (+0.59%) ⬆️
Parse/Parse/Source/PFQuery.m 94.30% <100.00%> (+0.02%) ⬆️
Parse/Tests/Unit/OfflineQueryLogicUnitTests.m 100.00% <100.00%> (ø)
Parse/Tests/Unit/QueryUnitTests.m 98.78% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title feat: Support query.containedBy feat: Add support for PFQuery.containedBy Jul 15, 2023
@dplewis dplewis requested a review from mtrezza July 20, 2023 16:12
mtrezza
mtrezza approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza merged commit 2316a3f into parse-community:master Jul 20, 2023
10 checks passed
parseplatformorg pushed a commit that referenced this pull request Jul 20, 2023
@semantic-release-bot
chore(release): 2.7.0 [skip ci]
4c130ee 
# [2.7.0](2.6.0...2.7.0) (2023-07-20)

### Features

* Add support for `PFQuery.containedBy` ([#1735](#1735)) ([2316a3f](2316a3f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 2.7.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jul 20, 2023
@dplewis dplewis deleted the query-containedBy branch July 21, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dplewis @parseplatformorg @mtrezza