Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build using Github Actions #35

Open
wants to merge 55 commits into
base: master
Choose a base branch
from

Conversation

cbaker6
Copy link

@cbaker6 cbaker6 commented Oct 31, 2021

Moves the CI to Github Actions.

  • Switch to Parse Alpha branch
  • Update codecov
  • Update package-lock.json for node 14

@cbaker6 cbaker6 marked this pull request as draft October 31, 2021 17:43
@cbaker6 cbaker6 marked this pull request as ready for review October 31, 2021 21:41
@cbaker6
Copy link
Author

cbaker6 commented Oct 31, 2021

@dplewis @mtrezza I think this is ready for review.

In terms of the release, I couldn't find this on npm and I see no releases here so I'm assuming it was never released.

Let me know if you see something I missed.

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b1ab2d3) compared to base (41daf4e).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head b1ab2d3 differs from pull request most recent head f650f01. Consider uploading reports for the commit f650f01 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          185       187    +2     
  Branches        26        28    +2     
=========================================
+ Hits           185       187    +2     
Impacted Files Coverage Δ
src/config.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cbaker6
Copy link
Author

cbaker6 commented Oct 16, 2022

@dplewis can you review this when you get a chance?

@cbaker6 cbaker6 closed this Oct 17, 2022
@cbaker6 cbaker6 reopened this Oct 17, 2022
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to release this as an official product. The last significant commit was made >2 years ago, so we'd first need to make sure this is up-to-date regarding security fixes, etc. We'd also have to add release automation, because it'd be too inefficient to manually maintain this "non-core" repo. Maybe we even need to generally review this, no sure whether this was ever intended to be released as an official product.

There are ongoing discussions that could lead to archiving this repo. Regarding its original purpose, I think it makes more sense to use a 3rd party perf testing tool, it seems to me we're reinventing the wheel here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants