Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one clang compilation error in the MinimalScheduler sample and the two currently failing tests:
@Unsigned
annotation to division in MinimalScheduler sampleCompilerPlugin.java
, this previously causedTypeProcessingTest#testIncludesAndInterface
to fail because of the extra newlines betweenx
andy
FEntryExitAutoAttachTest
:openat2
since this is what is triggered byTestUtil
/sys/*
filesinput.available() > 0
condition fromLineReader.ready()
. The trace pipe is not seekable, causing this condition to alway throw an exception, preventing LineReader from ever getting ready.readAllAvailableLines
to a do while-loop.I'm not totally happy with the trace changes to
FEntryExitAutoAttachTest
, but theready()
behaviour ofTraceLog
/the underlyingBufferedReader
isn't great. For example, it often seems to require a blockingread()
to report as ready. In some cases, this causes traces from one test to leak another one, which isn't ideal.A solution with GlobalVariables or a ring buffer would probably be better (for all tests).