Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors and failing tests #42

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

Mr-Pine
Copy link
Contributor

@Mr-Pine Mr-Pine commented Feb 16, 2025

This fixes one clang compilation error in the MinimalScheduler sample and the two currently failing tests:

  • Add @Unsigned annotation to division in MinimalScheduler sample
  • Remove two extra newlines in CompilerPlugin.java, this previously caused TypeProcessingTest#testIncludesAndInterface to fail because of the extra newlines between x and y
  • FEntryExitAutoAttachTest:
    • Change the used syscall to openat2 since this is what is triggered by TestUtil
    • Don't trace syscalls from other processes or with /sys/* files
    • Remove input.available() > 0 condition from LineReader.ready(). The trace pipe is not seekable, causing this condition to alway throw an exception, preventing LineReader from ever getting ready.
    • Change readAllAvailableLines to a do while-loop.

I'm not totally happy with the trace changes to FEntryExitAutoAttachTest, but the ready() behaviour of TraceLog/the underlying BufferedReader isn't great. For example, it often seems to require a blocking read() to report as ready. In some cases, this causes traces from one test to leak another one, which isn't ideal.
A solution with GlobalVariables or a ring buffer would probably be better (for all tests).

@parttimenerd parttimenerd merged commit 89f2c5f into parttimenerd:main Feb 16, 2025
1 of 2 checks passed
@Mr-Pine Mr-Pine deleted the build-and-test-fixes branch February 16, 2025 16:43
@parttimenerd
Copy link
Owner

It would probably be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants