Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw Faces of PathObject separately #218

Merged
merged 12 commits into from
Feb 17, 2022
Merged

Draw Faces of PathObject separately #218

merged 12 commits into from
Feb 17, 2022

Conversation

pasbi
Copy link
Owner

@pasbi pasbi commented Jan 2, 2022

Draw a circular path and another circular path completely within the first one (both paths are not connected but belong to the same PathObject).

  • Old behavior: There are two faces, the outer and the inner circle. If you assign a semi-transparent brush, you will notice that the inner of the inner circle is part of both faces (it's less transparent).
  • New behavior: The outer circle has a hole, the hole is drawn just once (because the inner circle covers it). Semi-transparent styles are rendered correctly.

This is important now for semi-transparent styles and will be even more important in the future when the filling can be enabled face-wise.

See #226

@pasbi pasbi force-pushed the enable-path-with-holes branch from 068e8e5 to abe5c04 Compare January 30, 2022 13:31
@pasbi pasbi force-pushed the enable-path-with-holes branch 2 times, most recently from 1641954 to f16c7b4 Compare February 7, 2022 21:12
Pascal Bies added 9 commits February 10, 2022 20:01
I have no clue why there are duplicates in that list. Didn't bother to investigate.
The flexibility was eventually not required actually, however, it does not add significant complexity.
# Conflicts:
#	src/path/path.cpp
Articulated edges are an edge case and can lead to non-intuitive results.
@pasbi pasbi force-pushed the enable-path-with-holes branch from f16c7b4 to 5a1d0c2 Compare February 10, 2022 19:02
@pasbi pasbi mentioned this pull request Feb 17, 2022
@pasbi pasbi changed the title Enable path with holes Draw Faces of PathObject separately Feb 17, 2022
@pasbi pasbi enabled auto-merge February 17, 2022 10:47
@pasbi pasbi merged commit afa8ec7 into main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant