Update runtime v1.3.1 #129
Conversation
raynaudoe
commented
Sep 7, 2024
•
raynaudoe
commented
- Upgrade relay chain to v1.3.1
- Upgrade system chains to v1.3.1
- Add coretime
Updates Snowbridge integration tests
Add coretime related files
Fix coretime compilation
More relay fixes
|
Tests have finished. Relay ChainStatus: failure System ParachainsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
|
Tests have finished. Relay ChainStatus: failure System ParachainsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
|
Tests have finished. BuildStatus: failure Relay ChainStatus: success System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
| fn default_parachains_host_configuration() -> HostConfiguration<polkadot_primitives::BlockNumber> { | ||
| use polkadot_primitives::{MAX_CODE_SIZE, MAX_POV_SIZE}; | ||
|
|
||
| runtime_parachains::configuration::HostConfiguration { |
There was a problem hiding this comment.
This appears to be the same as the one I reviewed in chat, worth checking the three that I highlighted:
- nodeFeatures are not set, which I think is required for some async backing functionality
- on-demand queue looks a fair bit bigger than polkadot and may lead to worse performance/higher weights. you might want to just double check that before using it
- ump limits are quite low, they should still be fine for coretime messages with the number of parachains you have, but some day that might be an issue
| // Measured: `2848` | ||
| // Estimated: `6313` | ||
| // Minimum execution time: 92_241_000 picoseconds. | ||
| Weight::from_parts(93_731_000, 0) |
There was a problem hiding this comment.
These are the exact same as Polkadot, when they're re-run you should check them against the hardcoded weights in the CoretimeInterface and ensure there's a big enough buffer to allow runtime upgrades of one chain without the other.
It's something to keep an eye on and keep the hardcoded weights up to date, trying to maintain the size of the buffer. If there are changes in weight larger than the buffer, you'd have to upgrade the other chain first with a weight bump, which isn't ideal.
| type Currency = Balances; | ||
| type OnRevenue = BurnCoretimeRevenue; | ||
| type TimeslicePeriod = ConstU32<{ coretime::TIMESLICE_PERIOD }>; | ||
| type MaxLeasedCores = ConstU32<55>; |
There was a problem hiding this comment.
It's unlikely that you'll ever need a value this high as this is only the legacy leases at the point they get ported over, but I guess you want it to be similar to Polkadot. It might come in useful in the future if permissionless coretime acquisition proves to be an issue with a token with no value.
Co-authored-by: Alejandro Martinez Andres <[email protected]>
|
Tests have finished. BuildStatus: cancelled Relay ChainStatus: cancelled System ParachainsStatus: cancelled Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
|
Tests have finished. BuildStatus: failure Relay ChainStatus: success System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
# Conflicts: # Cargo.lock # Cargo.toml # chain-spec-generator/src/common.rs # chain-spec-generator/src/main.rs # integration-tests/emulated/chains/parachains/bridges/bridge-hub-paseo/src/genesis.rs # integration-tests/emulated/chains/relays/paseo/src/genesis.rs # integration-tests/emulated/networks/paseo-system/src/lib.rs # integration-tests/emulated/tests/bridges/bridge-hub-paseo/src/lib.rs # integration-tests/emulated/tests/bridges/bridge-hub-paseo/src/tests/snowbridge.rs # relay/paseo/Cargo.toml # relay/paseo/src/impls.rs # relay/paseo/src/lib.rs # system-parachains/asset-hub-paseo/src/lib.rs # system-parachains/asset-hub-paseo/src/weights/cumulus_pallet_parachain_system.rs # system-parachains/asset-hub-paseo/src/weights/cumulus_pallet_xcmp_queue.rs # system-parachains/asset-hub-paseo/src/weights/frame_system.rs # system-parachains/asset-hub-paseo/src/weights/pallet_asset_conversion.rs # system-parachains/asset-hub-paseo/src/weights/pallet_assets_foreign.rs # system-parachains/asset-hub-paseo/src/weights/pallet_assets_local.rs # system-parachains/asset-hub-paseo/src/weights/pallet_assets_pool.rs # system-parachains/asset-hub-paseo/src/weights/pallet_balances.rs # system-parachains/asset-hub-paseo/src/weights/pallet_collator_selection.rs # system-parachains/asset-hub-paseo/src/weights/pallet_message_queue.rs # system-parachains/asset-hub-paseo/src/weights/pallet_multisig.rs # system-parachains/asset-hub-paseo/src/weights/pallet_nfts.rs # system-parachains/asset-hub-paseo/src/weights/pallet_proxy.rs # system-parachains/asset-hub-paseo/src/weights/pallet_session.rs # system-parachains/asset-hub-paseo/src/weights/pallet_timestamp.rs # system-parachains/asset-hub-paseo/src/weights/pallet_uniques.rs # system-parachains/asset-hub-paseo/src/weights/pallet_utility.rs # system-parachains/asset-hub-paseo/src/weights/pallet_xcm.rs # system-parachains/asset-hub-paseo/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs # system-parachains/asset-hub-paseo/src/weights/xcm/pallet_xcm_benchmarks_generic.rs # system-parachains/asset-hub-paseo/tests/weight_trader.rs # system-parachains/bridge-hub-paseo/Cargo.toml # system-parachains/bridge-hub-paseo/build.rs # system-parachains/bridge-hub-paseo/primitives/src/lib.rs # system-parachains/bridge-hub-paseo/src/bridge_to_kusama_config.rs # system-parachains/bridge-hub-paseo/src/lib.rs # system-parachains/bridge-hub-paseo/src/weights/cumulus_pallet_parachain_system.rs # system-parachains/bridge-hub-paseo/src/weights/cumulus_pallet_xcmp_queue.rs # system-parachains/bridge-hub-paseo/src/weights/frame_system.rs # system-parachains/bridge-hub-paseo/src/weights/mod.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_balances.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_bridge_grandpa.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_bridge_messages.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_bridge_parachains.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_bridge_relayers.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_collator_selection.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_message_queue.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_multisig.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_session.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_timestamp.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_utility.rs # system-parachains/bridge-hub-paseo/src/weights/pallet_xcm.rs # system-parachains/bridge-hub-paseo/src/weights/snowbridge_pallet_ethereum_client.rs # system-parachains/bridge-hub-paseo/src/weights/snowbridge_pallet_inbound_queue.rs # system-parachains/bridge-hub-paseo/src/weights/snowbridge_pallet_outbound_queue.rs # system-parachains/bridge-hub-paseo/src/weights/snowbridge_pallet_system.rs # system-parachains/bridge-hub-paseo/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs # system-parachains/bridge-hub-paseo/src/weights/xcm/pallet_xcm_benchmarks_generic.rs # system-parachains/bridge-hub-paseo/src/xcm_config.rs # system-parachains/bridge-hub-paseo/tests/snowbridge.rs # system-parachains/bridge-hub-paseo/tests/tests.rs # system-parachains/people-paseo/src/weights/cumulus_pallet_parachain_system.rs # system-parachains/people-paseo/src/weights/cumulus_pallet_xcmp_queue.rs # system-parachains/people-paseo/src/weights/frame_system.rs # system-parachains/people-paseo/src/weights/pallet_balances.rs # system-parachains/people-paseo/src/weights/pallet_collator_selection.rs # system-parachains/people-paseo/src/weights/pallet_identity.rs # system-parachains/people-paseo/src/weights/pallet_message_queue.rs # system-parachains/people-paseo/src/weights/pallet_multisig.rs # system-parachains/people-paseo/src/weights/pallet_proxy.rs # system-parachains/people-paseo/src/weights/pallet_session.rs # system-parachains/people-paseo/src/weights/pallet_timestamp.rs # system-parachains/people-paseo/src/weights/pallet_utility.rs # system-parachains/people-paseo/src/weights/pallet_xcm.rs # system-parachains/people-paseo/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs # system-parachains/people-paseo/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
|
Tests have finished. BuildStatus: failure Relay ChainStatus: cancelled System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
|
Tests have finished. BuildStatus: failure Relay ChainStatus: success System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
|
Tests have finished. BuildStatus: failure Relay ChainStatus: failure System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
|
Tests have finished. BuildStatus: failure Relay ChainStatus: success System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
|
Tests have finished. BuildStatus: failure Relay ChainStatus: success System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
|
Tests have finished. BuildStatus: failure Relay ChainStatus: success System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
|
Should all the tests pass for this PR? |
At least the integration tests should pass, I'm checking those now and trying to fix them. |
I can give a hand tomorrow, if you need it. :) Let me know. |
|
Tests have finished. BuildStatus: failure Relay ChainStatus: failure System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
Sure give it a look whenever you can, thanks! |
* test auto-gen chain specs * run on push * fix * install deps * add target * fix * Update chain specs * Add remaining specs * Update chain specs * Only commit on changes * Trigger on specific changes * Delete generated files * change job name * Try unify chain spec gen and runtime release creation * Add tag string to commit message * Remove unnecessary specs --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Tests have finished. BuildStatus: failure Relay ChainStatus: failure System ParachainsStatus: success Integration TestsStatus: failure ❌ Some tests have failed. Please check the details above for more information. |
