(PC-16618) fix(Web): optimisation lottie-web player #3351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-16618
Stratégie
J'ai modifié dans
node_modules/react-native-web-lottie/dist/index.js
l'import delottie-web
parlottie-web/build/player/lottie_light.min.js
, cette version supporte que les anims SVG, que nous utilisons exclusivement via des fichiers json fournis par nos UX.Ceci est appliqué sous forme d'un patch-package de
react-native-web-lottie
en attendant que soit résolu l'issue react-native-web-community/react-native-web-lottie#68La version “light” pesant 40.67KB Gzipped contre 65.99KB Gzipped actuel (gain de 37%)
Avant
Après
Checklist
I have:
($jira) $type($scope): $summary
.Screenshots