Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32766) fix(Offer): fix xp cine offers when offer has no allocineId #7125

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

inesmouandjolobe
Copy link
Contributor

@inesmouandjolobe inesmouandjolobe commented Oct 30, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32766

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
Desktop - Chrome Capture d’écran 2024-10-30 à 18 17 07 Capture d’écran 2024-10-30 à 18 15 49

Copy link

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Bookings page 100.1 ms → 102.8 ms (+2.7 ms, +2.7%) 11 → 11
Performance test for Offer page 73.0 ms → 75.1 ms (+2.1 ms, +2.9%) 2 → 2
Performance test for Venue page 2.9 ms → 3.3 ms (+0.4 ms, +13.8%) 2 → 2
Search Results - Performance test for Search Results page 14.0 ms → 14.2 ms (+0.2 ms, +1.4%) 5 → 5
Performance test for Favorites page 65.3 ms → 65.4 ms (+0.1 ms, ±0.0%) 6 → 6
Performance test for EndedBookings page 34.6 ms → 34.0 ms (-0.6 ms, -1.7%) 7 → 7
Search Landing Page - Performance test for Search Landing page 14.8 ms → 14.2 ms (-0.6 ms, -4.1%) 5 → 5
Performance test for Profile page 6.6 ms → 5.9 ms (-0.7 ms, -10.6%) 5 → 5
Show details
Name Render Duration Render Count
Performance test for Bookings page Baseline
Mean: 100.1 ms
Stdev: 2.3 ms (2.3%)
Runs: 104 103 102 100 100 99 99 99 99 96

Current
Mean: 102.8 ms
Stdev: 3.3 ms (3.2%)
Runs: 107 106 106 105 103 102 102 101 99 97
Baseline
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11

Current
Mean: 11
Stdev: 0 (0.0%)
Runs: 11 11 11 11 11 11 11 11 11 11
Performance test for Offer page Baseline
Mean: 73.0 ms
Stdev: 2.4 ms (3.3%)
Runs: 78 75 74 74 73 73 71 71 71 70

Current
Mean: 75.1 ms
Stdev: 2.7 ms (3.6%)
Runs: 79 78 77 76 76 75 74 74 71 71
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Performance test for Venue page Baseline
Mean: 2.9 ms
Stdev: 0.7 ms (25.4%)
Runs: 4 4 3 3 3 3 3 2 2 2

Current
Mean: 3.3 ms
Stdev: 0.8 ms (24.9%)
Runs: 4 4 4 4 4 3 3 3 2 2
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Search Results - Performance test for Search Results page Baseline
Mean: 14.0 ms
Stdev: 1.6 ms (11.2%)
Runs: 16 16 15 15 14 14 13 13 13 11

Current
Mean: 14.2 ms
Stdev: 1.5 ms (10.9%)
Runs: 16 16 15 15 15 14 14 13 13 11
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Favorites page Baseline
Mean: 65.3 ms
Stdev: 2.2 ms (3.3%)
Runs: 69 67 66 66 66 66 65 64 62 62

Current
Mean: 65.4 ms
Stdev: 2.7 ms (4.2%)
Runs: 70 68 67 67 66 65 64 63 63 61
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for EndedBookings page Baseline
Mean: 34.6 ms
Stdev: 1.4 ms (4.1%)
Runs: 37 36 36 35 35 34 34 33 33 33

Current
Mean: 34.0 ms
Stdev: 2.3 ms (6.6%)
Runs: 36 36 36 35 35 35 33 33 32 29
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 14.8 ms
Stdev: 2.3 ms (15.2%)
Runs: 18 18 16 15 15 15 15 12 12 12

Current
Mean: 14.2 ms
Stdev: 1.0 ms (7.3%)
Runs: 16 15 15 15 14 14 14 13 13 13
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Profile page Baseline
Mean: 6.6 ms
Stdev: 0.5 ms (7.8%)
Runs: 7 7 7 7 7 7 6 6 6 6

Current
Mean: 5.9 ms
Stdev: 0.7 ms (12.5%)
Runs: 7 7 6 6 6 6 6 5 5 5
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 8805429

Copy link

sonarcloud bot commented Oct 30, 2024

Copy link

sonarcloud bot commented Oct 30, 2024

@inesmouandjolobe inesmouandjolobe changed the title (BSR) fix(Offer): fix xp cine offers when offer has no allocineId (PC-32766) fix(Offer): fix xp cine offers when offer has no allocineId Oct 31, 2024
@inesmouandjolobe inesmouandjolobe merged commit 3859539 into master Oct 31, 2024
55 checks passed
@inesmouandjolobe inesmouandjolobe deleted the BSR/Fix-cine-offer-page branch October 31, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants