Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve excessive profile reloads #883

Merged
merged 5 commits into from
Nov 17, 2024
Merged

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Nov 17, 2024

Optimize ProfileManager in several ways:

  • Refine control over objectWillChange
  • Observe search separately
  • Store subscriptions separately (local, remote, search)
  • Fix multiple local updates on save/remove/foreground (updating allProfiles manually)
  • Update the library with more optimized NE reloads
  • Cancel pending remote import before a new one
  • Yield 100ms between imports
  • Reorganize code

Extras:

  • Only use background context in provider repositories
  • Externalize tunnel receipt URL, do not hardcode BundleConfiguration
  • Improve some logging

Self-reminder: NEVER use a Core Data background context to observe changes in CloudKit containers. They just won't be notified (e.g. in NSFetchedResultsController).

Fixes #857

Enough because only observed locally (pull behavior).
- Externalize tunnel receipt URL
- Indent logs
- Refine control over objectWillChange
- Observe search separately
- Store subscriptions separately
- Fix multiple local updates on save/remove
- Fix multiple local updates on foreground
- Cancel pending remote import before a new one
- Yield 100ms between imports
- Reorganize code
@keeshux keeshux self-assigned this Nov 17, 2024
@keeshux keeshux added bug Something isn't working enhancement New feature or request refactoring Improves software architecture labels Nov 17, 2024
@keeshux keeshux added this to the 3.0.0 / 5. Finalize milestone Nov 17, 2024
@keeshux keeshux merged commit d3e3446 into master Nov 17, 2024
1 check passed
@keeshux keeshux deleted the bugfix/excessive-profile-reloads branch November 17, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request refactoring Improves software architecture
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Excessive profile reloads on clean install
1 participant