Testing that an event is emitted when setting the score schema

contracts/GitcoinResolver.sol

@@ -31,6 +31,8 @@ contract GitcoinResolver is
   error NotAllowlisted();
   error InvalidAttester();
 
+  event ScoreSchemaSet(bytes32 schema);
+
   // Mapping of addresses to schemas to an attestation UID
   mapping(address => mapping(bytes32 => bytes32)) public userAttestations;
 
@@ -44,11 +46,10 @@ contract GitcoinResolver is
   mapping(address => bool) public allowlist;
 
   // Mapping of addresses to scores
-  mapping(address => CachedScore) private scores;
+  mapping(address => CachedScore) public scores;
 
   // Mapping of active passport score schemas - used when storing scores to state
-  // TODO: make this public
-  bytes32 private scoreSchema;
+  bytes32 public scoreSchema;
 
   /**
    * @dev Creates a new resolver.
@@ -100,8 +101,8 @@ contract GitcoinResolver is
    * @param _schema The score schema uid
    */
   function setScoreSchema(bytes32 _schema) external onlyOwner {
-    // TODO: emit event
     scoreSchema = _schema;
+    emit ScoreSchemaSet(_schema);
   }
 
   // solhint-disable-next-line no-empty-blocks

hardhat.config.ts

@@ -7,16 +7,31 @@ import "hardhat-gas-reporter";
 import "solidity-coverage";
 import "@openzeppelin/hardhat-upgrades";
 import "hardhat-contract-sizer";
+import { HttpNetworkHDAccountsConfig } from "hardhat/types";
 
 dotenv.config();
 
+
+// this is already a public mnemonic ...
+const MNEMONIC = "chief loud snack trend chief net field husband vote message decide replace";
+const testAccounts:HttpNetworkHDAccountsConfig = {
+  mnemonic: MNEMONIC,
+  path: "m/44'/60'/0'/0",
+  initialIndex: 0,
+  // We will use different recipients for some of the tests (like GitcoinResolver for example), 
+  // hence we need t ohave enough accounts
+  count: 30,
+  passphrase: "",
+};
+
 let config: HardhatUserConfig = {
   networks: {
     hardhat: {
       forking: {
-        url: process.env.PROVIDER_URL as string,
+        url: process.env.PROVIDER_URL as string
       },
-    },
+      accounts: testAccounts
+    }
   },
   etherscan: {
     apiKey: process.env.ETHERSCAN_API_KEY as string,
@@ -26,55 +41,55 @@ let config: HardhatUserConfig = {
         chainId: 59144,
         urls: {
           apiURL: "https://api.lineascan.build/api",
-          browserURL: "https://lineascan.build/",
-        },
+          browserURL: "https://lineascan.build/"
+        }
       },
       {
         network: "baseGoerli",
         chainId: 84531,
         urls: {
           apiURL: "https://api-goerli.basescan.org/api",
-          browserURL: "https://goerli.basescan.org/",
-        },
+          browserURL: "https://goerli.basescan.org/"
+        }
       },
       {
         network: "linea-goerli",
         chainId: 59140,
         urls: {
           apiURL: "https://api.lineascan.build/api",
-          browserURL: "https://goerli.lineascan.build/",
-        },
-      },
-    ],
+          browserURL: "https://goerli.lineascan.build/"
+        }
+      }
+    ]
   },
   gasReporter: {
     enabled: process.env.REPORT_GAS ? true : false,
-    coinmarketcap: process.env.COINMARKETCAP_API_KEY,
+    coinmarketcap: process.env.COINMARKETCAP_API_KEY
   },
   solidity: {
     settings: {
       optimizer: {
         enabled: true,
-        runs: 200,
+        runs: 200
       },
-      viaIR: true,
+      viaIR: true
     },
 
     compilers: [
       {
-        version: "0.8.0",
+        version: "0.8.0"
       },
       {
-        version: "0.8.9",
+        version: "0.8.9"
       },
       {
-        version: "0.8.18",
+        version: "0.8.18"
       },
       {
-        version: "0.8.19",
-      },
-    ],
-  },
+        version: "0.8.19"
+      }
+    ]
+  }
 };
 
 if (process.env.DEPLOYER_PRIVATE_KEY && process.env.DEPLOYER_ADDRESS) {
@@ -84,23 +99,23 @@ if (process.env.DEPLOYER_PRIVATE_KEY && process.env.DEPLOYER_ADDRESS) {
         url: process.env.PROVIDER_URL as string,
         accounts: [process.env.DEPLOYER_PRIVATE_KEY as string],
         chainId: 11155111,
-        from: process.env.DEPLOYER_ADDRESS as string,
+        from: process.env.DEPLOYER_ADDRESS as string
       };
     }
     if (process.env.OP_PROVIDER_URL) {
       config.networks["optimism"] = {
         url: process.env.OP_PROVIDER_URL as string,
         accounts: [process.env.DEPLOYER_PRIVATE_KEY as string],
         chainId: 10,
-        from: process.env.DEPLOYER_ADDRESS as string,
+        from: process.env.DEPLOYER_ADDRESS as string
       };
     }
     if (process.env.OP_GOERLI_PROVIDER_URL) {
       config.networks["optimism-goerli"] = {
         url: process.env.OP_GOERLI_PROVIDER_URL as string,
         accounts: [process.env.DEPLOYER_PRIVATE_KEY as string],
         chainId: 420,
-        from: process.env.DEPLOYER_ADDRESS as string,
+        from: process.env.DEPLOYER_ADDRESS as string
       };
     }
   }
@@ -135,7 +150,7 @@ if (
       url: process.env.CB_PROVIDER_URL as string,
       accounts: [process.env.CB_PRIVATE_KEY as string],
       chainId: 84531,
-      from: process.env.CB_ADDRESS as string,
+      from: process.env.CB_ADDRESS as string
     };
   }
 }

test/GitcoinResolver.ts

@@ -125,6 +125,26 @@ describe("GitcoinResolver", function () {
     };
   });
 
+  describe("Setup", function () {
+    it("should revert if non-wner tries to set a score schema", async function () {
+      await expect(
+        gitcoinResolver
+          .connect(nonOwnerOrVerifier)
+          .setScoreSchema(this.scoreSchemaId)
+      ).to.be.revertedWith("Ownable: caller is not the owner");
+    });
+    it("should emit event when a score schema is set", async function () {
+      const tx = await gitcoinResolver
+        .connect(owner)
+        .setScoreSchema(this.scoreSchemaId);
+      const receipt = await tx.wait();
+      const EasSetEvent = receipt.logs.filter((log: any) => {
+        return log.fragment.name == "ScoreSchemaSet";
+      });
+      expect(EasSetEvent.length).to.equal(1);
+      expect(EasSetEvent[0].args[0]).to.equal(this.scoreSchemaId);
+    });
+  });
   describe("Attestations", function () {
     it("should make 1 attestation", async function () {
       await gitcoinResolver.connect(mockEas).attest(this.validAttestation);