Improve and Add Comprehensive Test Coverage [#71]

[Paul-Taiwo]

This PR addresses the issue [#71]. Key changes include:

1. New Test Suites:

• Added client.test.ts to verify high-level registration/authentication flows via the WebAuthn API mocks.
• Updates server.test.ts covering signature verification, challenge checking, and data parsing on the server side.
• Update parsers.test.ts to ensure correct parsing of client data, authenticator data, and registration/authentication structures.

2. Refined Mocks & Setup:

• Centralized global mocks for navigator.credentials, PublicKeyCredential, crypto.subtle, etc. into a single Jest setup file, simplifying maintenance and reducing duplication.
• Used environment checks (Node vs. jsdom) to conditionally load mocks, ensuring tests run smoothly in both environments.

3. Enhanced Coverage:

• Added tests for edge cases (e.g., missing challenges, invalid base64url).
• Verified abort behavior for concurrent WebAuthn calls.
• Tested fallback logic for missing AAGUIDs and updated metadata.
• Test coverage up to 94.57%

[dagnelies]

That sounds awesome, can't wait to test it out 🚀

I'll review / try it later because I'm short on time right now, but at first glance I like it very much. Thanks 🙌

[dagnelies]

Hi @Paul-Taiwo. I reviewed your PR right now, and I noticed you moved a significant chunk of code from the server to utils. Why? Could you please revert that change? This would break lots of code out there. It would be ideal if this PR focuses solely on the test suite, not affecting the code itself.

[dagnelies]

I also think the "global.d.ts" should be moved to the test dir, or jest dir, and named "mocks" or so, to indicate clearly that it's a file for testing. Does it also have any impact on the production build?

[Paul-Taiwo]

Good points! The global.d.ts file is purely for typing the global mock variables. Regarding the production build, the declaration file don’t actually emit any JavaScript or impact runtime code, so they won’t alter the production bundle. Still, I've moved it into the jest_config file to keep things tidy and avoid confusion.

[Paul-Taiwo]

Hi @Paul-Taiwo. I reviewed your PR right now, and I noticed you moved a significant chunk of code from the server to utils. Why? Could you please revert that change? This would break lots of code out there. It would be ideal if this PR focuses solely on the test suite, not affecting the code itself.

The reason for splitting the functions out of the server.ts file is jest can’t mock same-file function calls by default. That means if verifyAuthentication() and verifySignature() (for example) both live in server.ts, any test that tries to mock verifySignature() will still end up calling the real function instead of the mock, because the file references it directly in-memory.

I’ll take another look to see if I can find an approach that won’t break the existing code.

[Paul-Taiwo]

I have reverted the change regarding the chunk of code that was moved to utils from the server and I also updated/added more test. The coverage is now at 97.27%

[dagnelies]

Upon further inspection, there is really a lot that is mocked and real payloads not tested at all. In the end, it tests very little and the coverage is quite misleading.

[Paul-Taiwo]

okay, I will review the test again.