Add a lock_ttl to the sidekiq jobs #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that the lock added by sidekiq-unique-jobs is not removed in exceptional scenarios (outage, server reboot, etc.). This prevents any further jobs from processing forever (or at least until the lock is cleared by redis expiry or dev intervention). Add a TTL so that in this case, things eventually start processing again. TTL is set to 1 hour, which seems like ample time to run jobs normally, but short enough that updates start working again quickly in the event of a problem.
JasonBarnabe
added a commit
to greasyfork-org/greasyfork
that referenced
this pull request
Jun 18, 2024
For adding a TTL on the locks - pat/ts-sidekiq-delta#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that the lock added by sidekiq-unique-jobs is not removed in exceptional scenarios (outage, server reboot, etc.). This prevents any further jobs from processing forever (or at least until the lock is cleared by redis expiry or dev intervention) and silently.
Add a TTL so that in this case, things eventually start processing again. TTL is set to 1 hour, which seems like ample time to run jobs normally, but short enough that updates start working again quickly in the event of a problem.