refactor: accessibility #1321
Merged
refactor: accessibility #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le attribute more information: https://dequeuniversity.com/rules/axe/4.1/frame-title
…st be unique IDs used in ARIA and labels must be unique: Document has multiple elements referenced with ARIA with the same id attribute, e.g. "global" more information: https://dequeuniversity.com/rules/axe/4.1/duplicate-id-aria
…ernible text: Element has no title attribute more information: https://dequeuniversity.com/rules/axe/4.1/button-name?application=axeAPI
<html> element must have a lang attribute: The <html> element does not have a lang attribute more information: https://dequeuniversity.com/rules/axe/4.2/html-has-lang
…alid values Invalid ARIA attribute value: e.g. aria-controls="atoms" The IDs were currently missing on the related ol elements - their value (and that for variable) needs to be equal to the aria-controls-attribute on the related NavTitle tag more information: https://dequeuniversity.com/rules/axe/4.2/aria-valid-attr-value
…ern… …ible text: Element has no title attribute The title-attribute needs to get transferred to the actual button itself, as this is the focusable element that even also gets recognized that read out loud by the screenreader. more information: https://dequeuniversity.com/rules/axe/4.1/button-name?application=axeAPI
JosefBredereck
approved these changes
May 17, 2021
antonia-rose
pushed a commit
to quelltexterin/nemo-uikit-workshop
that referenced
this pull request
Apr 12, 2023
* refactor(accessibility): axe/text-alternatives - Frames must have title attribute more information: https://dequeuniversity.com/rules/axe/4.1/frame-title * refactor(accessibility): axe/parsing - IDs used in ARIA and labels must be unique IDs used in ARIA and labels must be unique: Document has multiple elements referenced with ARIA with the same id attribute, e.g. "global" more information: https://dequeuniversity.com/rules/axe/4.1/duplicate-id-aria * refactor(accessibility): axe/name-role-value - Buttons must have discernible text: Element has no title attribute more information: https://dequeuniversity.com/rules/axe/4.1/button-name?application=axeAPI * refactor(accessibility): axe/language - added lang attribute <html> element must have a lang attribute: The <html> element does not have a lang attribute more information: https://dequeuniversity.com/rules/axe/4.2/html-has-lang * refactor(accessibility): axe/aria - ARIA attributes must conform to valid values Invalid ARIA attribute value: e.g. aria-controls="atoms" The IDs were currently missing on the related ol elements - their value (and that for variable) needs to be equal to the aria-controls-attribute on the related NavTitle tag more information: https://dequeuniversity.com/rules/axe/4.2/aria-valid-attr-value * refactor(accessibility): axe/name-role-value - Buttons must have discern… …ible text: Element has no title attribute The title-attribute needs to get transferred to the actual button itself, as this is the focusable element that even also gets recognized that read out loud by the screenreader. more information: https://dequeuniversity.com/rules/axe/4.1/button-name?application=axeAPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
webhint reported some accessibility problems, that the changes out of these code changes should fix.
Some remaining reportings are mainly related to the dependency
react-autosuggestand are even already reported over there: moroshko/react-autosuggest#778Another topic is related to a
tablistaria-role, which could get followed up with afterwards.Actually some code optimizations out of husky/prettier flipped through, so #1314 would be a good predecessor for a clearer picture on the changes of this pull request.