Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cleanup #827

Merged
merged 2 commits into from
Mar 16, 2018
Merged

More cleanup #827

merged 2 commits into from
Mar 16, 2018

Conversation

bmuenzenmeyer
Copy link
Member

Part of #815

Summary of changes:

  • hoists common devDependencies so we are on the same version of eslint* and prettier
  • excludes tests from code coverage

@bmuenzenmeyer bmuenzenmeyer self-assigned this Mar 16, 2018
@bmuenzenmeyer
Copy link
Member Author

I expect coverage to go down after it was artificially inflated

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.3%) to 63.532% when pulling 288ccaa on hoisting into 026e810 on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit f923a78 into dev Mar 16, 2018
@bmuenzenmeyer bmuenzenmeyer deleted the hoisting branch March 16, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmuenzenmeyer @coveralls