Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

Add missing fonts folder #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waynetheisinger
Copy link

Fixes issue #4 :

Expected Result

Installing using patternlab init and choosing starter kit mustache-base installs smoothly

Actual Result

Error: ENOENT: no such file or directory, lstat 'source/fonts'

Steps to reproduce
  1. patternlab init
  2. choose current directory
  3. choose node edition
  4. choose mustache base starterkit

@bradfrost
Copy link
Member

Hi @waynetheisinger, thanks for this. Do I have it right that you're adding a fonts folder and adding an icon font to that folder?

If the issue is that fonts directory doesn't exist, then it's fine to add an empty directory. However, we shouldn't be adding icon fonts to the mix because:

  1. PL lets people bring their own fonts and assets to the table
  2. Icon fonts shouldn't be used on projects for a number of reasons

If you remove the icon fonts but leave the directory, I can merge this in, thanks!

@waynetheisinger
Copy link
Author

waynetheisinger commented May 24, 2019

Hi @bradfrost It's presently throwing an error - so I added the font it was looking for in order stop the error being thrown - if you don't want to actually add the font then someone is going to have to work out what is calling it and remove the call... which is probably task for someone more familiar with things than I ... at least until I become more familiar myself, so shall I close this PR and change it to an issue instead?

Edit: Tomorrow I will have a go at adding just the folder as you suggested... it might then give a more descriptive error that will either let me solve it... or at least flesh the issue out a little...

@bradfrost
Copy link
Member

work out what is calling it and remove the call... which is probably task for someone more familiar with things than I ... at least until I become more familiar myself, so shall I close this PR and change it to an issue instead?

@waynetheisinger yeah that sounds like the right call if adding the empty folder doesn't pan out. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants