Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(usage-and-behavior): updates usage and behavior guidelines as part of content audit. #3735

Merged
merged 11 commits into from
Sep 27, 2023
Merged

docs(usage-and-behavior): updates usage and behavior guidelines as part of content audit. #3735

merged 11 commits into from
Sep 27, 2023

Conversation

edonehoo
Copy link
Collaborator

Closese #3734

@edonehoo edonehoo self-assigned this Aug 25, 2023
@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 25, 2023 •
edited
Loading

Preview: https://patternfly-org-pr-3735-site.surge.sh

@edonehoo
Copy link
Collaborator Author

edonehoo commented Aug 25, 2023 •
edited
Loading

curious for thoughts/opinions on the table change I'm suggesting. Can easily swap back, but I felt like this new approach might make it easier for users to quickly find the component they need (also felt like the footnotes were more disconnected from the info).

Now I'm unsure if it's a better or worse change, because icons are kind of quickly identifiable?

If I kept the new look, I could also change the "recommended components" column to separate recommended components with a new line (rather than listing them in one line)?

recommended component
Table
Table
Data list

Note: bla bla
Data list

andrew-ronaldson
andrew-ronaldson requested changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good. I saw that there was a styling break on the select between options on a form.
Other that that looks good to me.

andrew-ronaldson
andrew-ronaldson previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@mmenestr mmenestr merged commit 71503e3 into patternfly:main Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmenestr mmenestr mmenestr approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson left review comments

Assignees

@edonehoo edonehoo

Labels
Content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edonehoo @patternfly-build @andrew-ronaldson @mmenestr