Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix broken links in a few places for v5 site. #4045

Merged
merged 2 commits into from
Jun 4, 2024
Merged

docs: Fix broken links in a few places for v5 site. #4045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa3693a
docs: Fix broken links in a few places.
edonehoo May 29, 2024
661a904
Typo.
edonehoo May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/documentation-framework/components/footer/footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,34 +30,34 @@ export const Footer = () => (
<Link
className="ws-org-pfsite-footer-menu-link"
to={"/get-started/about-patternfly"}
aria-label="Get started with PatternFly 4"
aria-label="Get started with PatternFly"
>
Get started
</Link>
</li>
<li className="ws-org-pfsite-footer-menu-list-item">
<Link
className="ws-org-pfsite-footer-menu-link"
to="/components/about-modal"
aria-label="PatternFly 4 components"
to="/components/all-components"
aria-label="PatternFly components"
>
Components
</Link>
</li>
<li className="ws-org-pfsite-footer-menu-list-item">
<Link
className="ws-org-pfsite-footer-menu-link"
to="/layouts/bullseye"
aria-label="PatternFly 4 layouts"
to="/layouts/about-layouts"
aria-label="PatternFly layouts"
>
Layouts
</Link>
</li>
<li className="ws-org-pfsite-footer-menu-list-item">
<Link
className="ws-org-pfsite-footer-menu-link"
to="/design-foundations/colors"
aria-label="PatternFly 4 styles"
to="/design-foundations/about-design-foundations"
aria-label="PatternFly styles"
>
Styles
</Link>
Expand Down Expand Up @@ -98,7 +98,7 @@ export const Footer = () => (
className="ws-org-pfsite-footer-menu-link"
to="https://github.com/patternfly/patternfly/blob/main/CODE_OF_CONDUCT.md"
target="top"
aria-label="PatternFly 4 Code of Conduct"
aria-label="PatternFly Code of Conduct"
>
Code of Conduct
</Link>
Expand All @@ -121,7 +121,7 @@ export const Footer = () => (
className="ws-org-pfsite-footer-menu-link"
to="//join.slack.com/t/patternfly/shared_invite/zt-1npmqswgk-bF2R1E2rglV8jz5DNTezMQ"
target="top"
aria-label="Join the PatternFly 4 Slack"
aria-label="Join the PatternFly Slack"
>
Slack
</Link>
Expand Down Expand Up @@ -151,7 +151,7 @@ export const Footer = () => (
className="ws-org-pfsite-footer-menu-link"
to="//medium.com/patternfly"
target="top"
aria-label="Read the PatternFly 4 blog"
aria-label="Read the PatternFly blog"
>
PatternFly Medium
</Link>
Expand Down
6 changes: 3 additions & 3 deletions ...tation-site/patternfly-docs/content/design-guidelines/components/alert/alert.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Use an alert component when you are trying to give the user essential informatio

If your use case falls outside of PatternFly's standard alert variations, use [icons](/design-foundations/icons) and [colors](/design-foundations/colors) to create custom alerts that meet your needs.

View custom alerts in action in our [custom alert examples](https://www.patternfly.org/v4/components/alert#custom-icons).
View custom alerts in action in our [custom alert examples](/components/alert#custom-icons).

### Managing overflow

Expand All @@ -67,7 +67,7 @@ The overflow link should be configured to navigate to a place where the user can

<img src="./img/alert-group-with-overflow.png" alt="An example of an alert group with overflow footer" width="662" />

See our [toast alert guidelines](/components/alert/design-guidelines/#using-toast-alerts) for more information about using toast alerts.
See our [toast alert guidelines](#toast-alerts) for more information about using toast alerts.

## Placement
Toast alerts should be placed in an alert group in the upper-right corner of a page. Use 8px of padding between each alert in an alert group. Alert group alignment on a page will depend on your use case.
Expand Down Expand Up @@ -105,7 +105,7 @@ Toast alerts are commonly used in the following situations:

<img src="./img/alert-group-mobile.png" alt="An example of a centered toast alert group over a mobile view." width="375" />

See our [toast alert guidelines](/components/alert/design-guidelines/#using-toast-alerts) for more information about using toast alerts.
See our [toast alert guidelines](#toast-alerts) for more information about using toast alerts.


### Bordered inline alerts
Expand Down
8 changes: 4 additions & 4 deletions ...patternfly-docs/content/design-guidelines/components/date-picker/date-picker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Some use cases may call for a two-lined toolbar. If your toolbar spans two lines

<img src="./img/In toolbar filter group vertical.png" alt="Example of date picker in toolbar filter group - two liner" width="457"/>

For more information about using different types of filters, see our [filters guidelines](/patterns/filters).
For more information about using different types of filters, see our [filters guidelines](/patterns/filters/design-guidelines).

##### Additional dropdown for simplified date-range filtering
Add an optional dropdown to date-range filters within a toolbar to allow users to filter by the most common date-range options associated with the corresponding table.
Expand Down Expand Up @@ -120,15 +120,15 @@ Example: MM/DD/YYYY

<img src="./img/placeholder date picker.png" alt="Placeholder text in date picker" width="200"/>

For more information about writing effective placeholder text, see our <a href="https://www.patternfly.org/v4/components/form/design-guidelines">form design guidelines</a>.
For more information about writing effective placeholder text, see our [form design guidelines.](/components/forms/form/design-guidelines)


### Helper text
Use helper text to provide permanent guidance below the date field.

<img src="./img/helper text date picker.png" alt="Date picker witth helper text" width="200"/>

For more information about writing effective placeholder text, see our <a href="https://www.patternfly.org/v4/components/form/design-guidelines">form design guidelines</a>.
For more information about writing effective placeholder text, see our [form design guidelines.](/components/forms/form/design-guidelines)

### Error message
Use field level error messages to alert users when their inputted date or date format is invalid. Always specify what went wrong so that users can quickly identify the problem and fix it.
Expand All @@ -139,4 +139,4 @@ Examples:

<img src="./img/Error message date picker.png" alt="Date picker with error message" width="200"/>

For more information about writing effective error messages, see our <a href="https://www.patternfly.org/v4/ux-writing/error-messages/">UX writing style guide</a>.
For more information about writing effective error messages, see our [UX writing style guide.](/ux-writing/about-ux-writing)
2 changes: 1 addition & 1 deletion ...s/documentation-site/patternfly-docs/content/get-started/community/community.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ import CalendarIcon from '@patternfly/react-icons/dist/esm/icons/calendar-alt-ic
A community isn't really a community unless everyone is included, so accessible UX is important to us. We regularly test and audit PatternFly's accessibility and share guidance whenever we can.
</p>
<Title size="xl" className="ws-title" headingLevel="h3">
<Link to="/accessibility/accessibility-fundamentals">
<Link to="/accessibility/about-accessibility">
Read our accessibility guide
</Link>
</Title>
Expand Down
6 changes: 3 additions & 3 deletions ...es/documentation-site/patternfly-docs/content/get-started/release-highlights.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ The following pages now have updated content -- take a read!

- [About accessibility](/accessibility/about-accessibility) (formerly named "Accessibility fundamentals")
- [Accessibility scorecard](/accessibility/accessibility-scorecard)
- [Design for accessibility](/accessibility/accessibility-design) (**new!**)
- [Design for accessibility](/accessibility/design-for-accessibility) (**new!**)
- [Develop for accessibility](/accessibility/develop-for-accessibility) (formerly named "Product development guide")
- [PatternFly's accessibility](/accessibility/patternflys-accessibility)
- [Testing your accessibility](/accessibility/testing-your-accessibility)
Expand Down Expand Up @@ -384,7 +384,7 @@ We are committed to supporting the 2 most recent versions of React for PatternFl

We wanted to ensure that our variable naming conventions were clear and consistent going forward with our future release cycles. To keep things organized and clear, we updated our CSS variables and class names so that they are explicitly associated with the version of PatternFly that they align to. For PatternFly 5, we added a prefix of `v5` to a number of our variable and class names.

For more details, refer to [our upgrade guide](/get-started/upgrade#review-and-update-variable-and-class-names) and our [updated CSS classes and variables](developer-resources/global-css-variables) documentation.
For more details, refer to [our upgrade guide](/get-started/upgrade#review-and-update-variable-and-class-names) and our [updated CSS classes and variables](/developer-resources/global-css-variables) documentation.

### Event handler parameter consistency updates

Expand All @@ -410,7 +410,7 @@ The following updates were made to the card component to improve the experience

Our previous card API was difficult to understand and utilize. We reconfigured its markup and React subcomponents so you can implement cards more easily.

As a result, `CardHeaderMain` and `CardActions` are no longer exported from PatternFly, and are instead rendered internally within the `CardHeader` sub-component. Any content and properties for `CardHeaderMain` or `CardActions` should be passed directly to [`CardHeader`](https://www.patternfly.org/v4/components/card#cardheader) instead.
As a result, `CardHeaderMain` and `CardActions` are no longer exported from PatternFly, and are instead rendered internally within the `CardHeader` sub-component. Any content and properties for `CardHeaderMain` or `CardActions` should be passed directly to [`CardHeader`](https://v4-archive.patternfly.org/v4/components/card#cardheader) instead.

**Clickable and selectable cards**

Expand Down
Loading