fix: Reenabled patternfly quickstarts. #4267
Conversation
|
@dlabaj I think this build will pass if you make sure the version of the @patternfly/documentation-framework matches the version of that dependency being pulled into the documentation-site. |
There was a problem hiding this comment.
The @patternfly/documentation-framework dependency on line 20 should be bumped to 6.0.0-alpha.102 to match the current docs-framework version - this update resolved the CI build error for me locally.
yarn.lock
Outdated
| @@ -1787,6 +1787,74 @@ | |||
| "@patternfly/react-core" "6.0.0-alpha.94" | |||
| commander "^12.0.0" | |||
|
|
|||
| "@patternfly/[email protected]": | |||
There was a problem hiding this comment.
I think these lines in the yarn.lock file should be unnecessary. are they being pulled in if you run yarn install again?
Quickstarts shouldn't be requiring you to pull it in, I don't think.
There was a problem hiding this comment.
Good catch. Thanks @nicolethoen
|
I think if you run |
| @@ -26,6 +26,7 @@ | |||
| "@patternfly/react-user-feedback": "6.0.0-prerelease.1", | |||
| "@patternfly/react-component-groups": "6.0.0-prerelease.3", | |||
| "@patternfly/react-virtualized-extension": "6.0.0-prerelease.3", | |||
| "@patternfly/quickstarts": "6.0.0-alpha.5", | |||
There was a problem hiding this comment.
Did you want to pull in version 6.0.0-prerelease.1 of quickstarts? That'll include the updated design guidelines that Erin just finished.
Fixes issue #4251 by reenabling quickstarts.