Skip to content

Commit

Permalink
fix: add pf-v5-c-table__body class (#24)
Browse files Browse the repository at this point in the history 
* fix: add pf-v5-c-table__body class

* after rebase
  • Loading branch information
@nicolethoen
nicolethoen authored Nov 14, 2023
1 parent 5cfa6cf commit 81bbef9
Show file tree
Hide file tree
Showing 11 changed files with 87 additions and 91 deletions.
14 changes: 7 additions & 7 deletions packages/module/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
"tag": "prerelease"
},
"dependencies": {
"@patternfly/react-core": "^5.0.0",
"@patternfly/react-icons": "^5.0.0",
"@patternfly/react-styles": "^5.0.0",
"@patternfly/react-core": "^5.1.1",
"@patternfly/react-icons": "^5.1.1",
"@patternfly/react-styles": "^5.1.1",
"linear-layout-vector": "0.0.1",
"react-virtualized": "^9.22.5",
"tslib": "^2.5.2"
Expand All @@ -51,10 +51,10 @@
"react-dom": "^17 || ^18"
},
"devDependencies": {
"@patternfly/documentation-framework": "^5.0.15",
"@patternfly/patternfly": "^5.0.0",
"@patternfly/react-table": "^5.0.0",
"@patternfly/react-code-editor": "^5.0.0",
"@patternfly/documentation-framework": "^5.3.6",
"@patternfly/patternfly": "^5.1.0",
"@patternfly/react-table": "^5.1.1",
"@patternfly/react-code-editor": "^5.1.1",
"rimraf": "^5.0.1",
"@patternfly/patternfly-a11y": "^4.3.1",
"react-monaco-editor": "^0.51.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/module/patternfly-docs/content/examples/Actions.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class ActionsExample extends React.Component {

return (
<CellMeasurer cache={measurementCache} columnIndex={0} key={key} parent={parent} rowIndex={index}>
<tr data-id={index} style={style} role="row">
<tr className="pf-v5-c-table__tr" data-id={index} style={style} role="row">
<td className={columns[0].props.className} role="gridcell">
{rows[index].cells[0]}
</td>
Expand Down
2 changes: 1 addition & 1 deletion packages/module/patternfly-docs/content/examples/Basic.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export class VirtualizedExample extends React.Component {

return (
<CellMeasurer cache={measurementCache} columnIndex={0} key={key} parent={parent} rowIndex={index}>
<tr style={style} role="row">
<tr className="pf-v5-c-table__tr" style={style} role="row">
<td className={columns[0].props.className} role="gridcell">
{rows[index].cells[0]}
</td>
Expand Down
2 changes: 1 addition & 1 deletion packages/module/patternfly-docs/content/examples/FilterableWithWindowScroller.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ export class FilterExample extends React.Component {

return (
<CellMeasurer cache={measurementCache} columnIndex={0} key={key} parent={parent} rowIndex={index}>
<tr data-id={index} style={style} role="row">
<tr className="pf-v5-c-table__tr" data-id={index} style={style} role="row">
<td role="gridcell">{filteredRows[index].cells[0]}</td>
<td role="gridcell">{filteredRows[index].cells[1]}</td>
<td role="gridcell">{filteredRows[index].cells[2]}</td>
Expand Down
2 changes: 1 addition & 1 deletion packages/module/patternfly-docs/content/examples/Selectable.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class SelectableExample extends React.Component {

return (
<CellMeasurer cache={measurementCache} columnIndex={0} key={key} parent={parent} rowIndex={index}>
<tr data-id={index} style={style} role="row">
<tr className="pf-v5-c-table__tr" data-id={index} style={style} role="row">
<td data-key="0" className="pf-v5-c-table__check" role="gridcell">
<input
type="checkbox"
Expand Down
2 changes: 1 addition & 1 deletion packages/module/patternfly-docs/content/examples/Sortable.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export class SortableExample extends React.Component {

return (
<CellMeasurer cache={measurementCache} columnIndex={0} key={key} parent={parent} rowIndex={index}>
<tr style={style} role="row">
<tr className="pf-v5-c-table__tr" style={style} role="row">
<td className={columns[0].props.className} role="gridcell">
{rows[index].cells[0]}
</td>
Expand Down
14 changes: 7 additions & 7 deletions packages/module/patternfly-docs/content/examples/WindowScroller.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,21 @@ export class WindowScrollerExample extends React.Component {
columns: [
{
title: 'Repositories',
props: { className: 'pf-m-6-col-on-sm pf-m-4-col-on-md pf-m-3-col-on-lg pf-m-2-col-on-xl' }
props: { className: 'pf-v5-c-table__th pf-m-6-col-on-sm pf-m-4-col-on-md pf-m-3-col-on-lg pf-m-2-col-on-xl' }
},
{
title: 'Branches',
props: { className: 'pf-m-6-col-on-sm pf-m-4-col-on-md pf-m-3-col-on-lg pf-m-2-col-on-xl' }
props: { className: 'pf-v5-c-table__th pf-m-6-col-on-sm pf-m-4-col-on-md pf-m-3-col-on-lg pf-m-2-col-on-xl' }
},
{
title: 'Pull requests',
props: { className: 'pf-m-4-col-on-md pf-m-4-col-on-lg pf-m-3-col-on-xl pf-m-hidden pf-m-visible-on-md' }
props: { className: 'pf-v5-c-table__th pf-m-4-col-on-md pf-m-4-col-on-lg pf-m-3-col-on-xl pf-m-hidden pf-m-visible-on-md' }
},
{
title: 'Workspaces',
props: { className: 'pf-m-2-col-on-lg pf-m-2-col-on-xl pf-m-hidden pf-m-visible-on-lg' }
props: { className: 'pf-v5-c-table__th pf-m-2-col-on-lg pf-m-2-col-on-xl pf-m-hidden pf-m-visible-on-lg' }
},
{ title: 'Last Commit', props: { className: 'pf-m-3-col-on-xl pf-m-hidden pf-m-visible-on-xl' } }
{ title: 'Last Commit', props: { className: 'pf-v5-c-table__th pf-m-3-col-on-xl pf-m-hidden pf-m-visible-on-xl' } }
],
rows
};
Expand Down Expand Up @@ -86,7 +86,7 @@ export class WindowScrollerExample extends React.Component {

return (
<CellMeasurer cache={this._cellMeasurementCache} columnIndex={0} key={key} parent={parent} rowIndex={index}>
<tr style={style} role="row">
<tr className="pf-v5-c-table__tr" style={style} role="row">
<td className={columns[0].props.className} role="gridcell">
{text}
</td>
Expand Down Expand Up @@ -140,7 +140,7 @@ export class WindowScrollerExample extends React.Component {
<VirtualTableBody
ref={this._bindBodyRef}
autoHeight
className={'pf-v5-c-virtualized pf-v5-c-window-scroller'}
className={'pf-v5-c-table pf-v5-c-virtualized pf-v5-c-window-scroller'}
deferredMeasurementCache={this._cellMeasurementCache}
rowHeight={this._cellMeasurementCache.rowHeight}
height={height || 0}
Expand Down
16 changes: 7 additions & 9 deletions packages/module/patternfly-docs/generated/extensions/virtual-scroll-table/react.js
View file

Large diffs are not rendered by default.

8 changes: 3 additions & 5 deletions packages/module/patternfly-docs/generated/extensions/virtual-scroll-window-scroller/react.js
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/module/src/components/Virtualized/VirtualGrid.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ export class VirtualGrid extends React.Component<VirtualGridProps, VirtualGridSt
let innerScrollContainer = null;
if (childrenToDisplay.length > 0) {
const innerScrollContainerProps = {
className: 'ReactVirtualized__VirtualGrid__innerScrollContainer',
className: 'ReactVirtualized__VirtualGrid__innerScrollContainer pf-v5-c-table__tbody',
key: 'ReactVirtualized__VirtualGrid__innerScrollContainer',
role: containerRole,
style: {
Expand Down
114 changes: 57 additions & 57 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2070,21 +2070,21 @@
"@nodelib/fs.scandir" "2.1.5"
fastq "^1.6.0"

"@patternfly/ast-helpers@^0.4.57":
version "0.4.79"
resolved "https://registry.yarnpkg.com/@patternfly/ast-helpers/-/ast-helpers-0.4.79.tgz#7d738323681d5a1138d973b1daf534f1a05080b2"
integrity sha512-Nn2Uut7Z1nQwDr5LAf1bns6yCFQFQWwXE2I1Ucvbk6s2Gl2X/85VGvww8FVO+YiW/plLZMLBFRPJMP4fs2N8Cg==
"@patternfly/ast-helpers@^1.3.6":
version "1.3.6"
resolved "https://registry.yarnpkg.com/@patternfly/ast-helpers/-/ast-helpers-1.3.6.tgz#b8b45e8dbfc802b0ebf35976948d30834ac2a432"
integrity sha512-dj3x+jQpeBamSiNSDq6EMPB6Q+1myzFYVBBai12FpqhrnYCkOjTGDok8VflBo5tOVLKuTdhBNbvkd7V7c0DRvw==
dependencies:
acorn "^8.4.1"
acorn-class-fields "^1.0.0"
acorn-jsx "^5.3.2"
acorn-static-class-features "^1.0.0"
astring "^1.7.5"

"@patternfly/documentation-framework@^5.0.15":
version "5.0.15"
resolved "https://registry.yarnpkg.com/@patternfly/documentation-framework/-/documentation-framework-5.0.15.tgz#56e6608de10a95a92787686e5db1eb3ff7c09b89"
integrity sha512-3r9fqPeAKY8GeJM6m7VPyPsiggxhyDbbWTo2/4T4NoNisVPpFXi0AzUaTpvJU2KcBx5pSot1mb84V3f8DHzWXg==
"@patternfly/documentation-framework@^5.3.6":
version "5.3.6"
resolved "https://registry.yarnpkg.com/@patternfly/documentation-framework/-/documentation-framework-5.3.6.tgz#eb3b2793376fd6a832243353b5e7a6b32ac67a63"
integrity sha512-u8jUZ7YpGfF5kjMo9bJHw40Fo6twVHRZOeKrtMLqZMjIaSMI1B/etNG4fcIKr93Q1DxKQ1c3OcYvHv4Nd5KPIA==
dependencies:
"@babel/core" "7.18.2"
"@babel/plugin-proposal-class-properties" "7.17.12"
Expand All @@ -2094,7 +2094,7 @@
"@babel/plugin-transform-react-jsx" "7.17.12"
"@babel/preset-env" "7.18.2"
"@mdx-js/util" "1.6.16"
"@patternfly/ast-helpers" "^0.4.57"
"@patternfly/ast-helpers" "^1.3.6"
"@reach/router" "npm:@gatsbyjs/[email protected]"
autoprefixer "9.8.6"
babel-loader "9.1.2"
Expand Down Expand Up @@ -2170,60 +2170,60 @@
puppeteer-cluster "^0.23.0"
xmldoc "^1.1.2"

"@patternfly/patternfly@^5.0.0":
version "5.0.2"
resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-5.0.2.tgz#f5daf2c98ccb85e6466d42fd61d39ba3c10ed532"
integrity sha512-PB8+MLdYVgF1hIOxGmnVsZG+YHUX3RePe5W1oMS4gS00EmSgw1cobr1Qbpy/BqqS8/R9DRN4hZ2FKDT0d5tkFQ==
"@patternfly/patternfly@^5.1.0":
version "5.1.0"
resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-5.1.0.tgz#1c02dff6785d87c222de8a5944b960dd6c0de760"
integrity sha512-wzVgL/0xPsmuRKWc6lMNEo5gDcTUtyU231eJSBTapOKXiwBOv2flvLEHPYLO6oDYXO+hwUrVgbcZFWMd1UlLwA==

"@patternfly/react-code-editor@^5.0.0":
version "5.0.0"
resolved "https://registry.yarnpkg.com/@patternfly/react-code-editor/-/react-code-editor-5.0.0.tgz#2ba9d49a84023907b94fcbec13ec62b2d463d33e"
integrity sha512-Ya1nuw2Zcor/MET+s0+VuYq2VsRb+VzKpZQ8Y1MbrXJdlWV6QS5Wf1M7jDl9lYkiJaS3pjG7eXNeVX2YJ+mQiw==
"@patternfly/react-code-editor@^5.1.1":
version "5.1.1"
resolved "https://registry.yarnpkg.com/@patternfly/react-code-editor/-/react-code-editor-5.1.1.tgz#1b038ad71bdfc0d6a9f896e416f764fe3487c308"
integrity sha512-Y7+rr8O3BdomCDUnp3hoBnw1j08G18Q5GOXx1bX3Zksc8P2T3oZa+TL3zyDMIEZfEftRfkSGXtaACUFwmXlQIQ==
dependencies:
"@patternfly/react-core" "^5.0.0"
"@patternfly/react-icons" "^5.0.0"
"@patternfly/react-styles" "^5.0.0"
"@patternfly/react-core" "^5.1.1"
"@patternfly/react-icons" "^5.1.1"
"@patternfly/react-styles" "^5.1.1"
react-dropzone "14.2.3"
tslib "^2.5.0"

"@patternfly/react-core@^5.0.0":
version "5.0.0"
resolved "https://registry.yarnpkg.com/@patternfly/react-core/-/react-core-5.0.0.tgz#96c9e2315047eec94d28f5621c02fa147182dd6f"
integrity sha512-kewRVFhLw0Dvt8250pqrO47sVRx8E93sMGZbHQomJnZdachYeQ9STnQTP2gvOBq/GPnMei0LZLv0T99g8mPE4w==
"@patternfly/react-core@^5.1.1":
version "5.1.1"
resolved "https://registry.yarnpkg.com/@patternfly/react-core/-/react-core-5.1.1.tgz#9f0c5578c400e8808c56f160f3dd02801c430d3f"
integrity sha512-9DbgQMXYmF8A4aCNLKXwIN1H07SIPoPaVLvx+yiDuJfDx4Qi0T+H7j5cx0VfDfxuCpqea3POJWqBQn1HnwS4wQ==
dependencies:
"@patternfly/react-icons" "^5.0.0"
"@patternfly/react-styles" "^5.0.0"
"@patternfly/react-tokens" "^5.0.0"
focus-trap "7.4.3"
"@patternfly/react-icons" "^5.1.1"
"@patternfly/react-styles" "^5.1.1"
"@patternfly/react-tokens" "^5.1.1"
focus-trap "7.5.2"
react-dropzone "^14.2.3"
tslib "^2.5.0"

"@patternfly/react-icons@^5.0.0":
version "5.0.0"
resolved "https://registry.yarnpkg.com/@patternfly/react-icons/-/react-icons-5.0.0.tgz#bb56ead97425f1b3ab886ee291ba6b6af4088e9d"
integrity sha512-GG5Y/UYl0h346MyDU9U650Csaq4Mxk8S6U8XC7ERk/xIrRr2RF67O2uY7zKBDMTNLYdBvPzgc2s3OMV1+d2/mg==
"@patternfly/react-icons@^5.1.1":
version "5.1.1"
resolved "https://registry.yarnpkg.com/@patternfly/react-icons/-/react-icons-5.1.1.tgz#be1249e2f3abdc0e280952f88c3d5deb07fe1dde"
integrity sha512-9gCxkWz2xcdi0rtXu2F0L68w4tLIlsgGTACo1ggr4aVng9jRX++o1PlCOqscOd9o0NiFnFD7BLlZUGvJWaYEZg==

"@patternfly/react-styles@^5.0.0":
version "5.0.0"
resolved "https://registry.yarnpkg.com/@patternfly/react-styles/-/react-styles-5.0.0.tgz#63705ad498ff271fd056e92bd07b2c720ef3491a"
integrity sha512-xbSCgjx+fPrXbIzUznwTFWtJEbzVS0Wn4zrejdKJYQTY+4YcuPlFkeq2tl3syzwGsaYMpHiFwQiTaKyTvlwtuw==
"@patternfly/react-styles@^5.1.1":
version "5.1.1"
resolved "https://registry.yarnpkg.com/@patternfly/react-styles/-/react-styles-5.1.1.tgz#73762306972e520c2eff63a8b5412914c51a2ca8"
integrity sha512-swO9X+WixYYDsMVsEJp1V8QUfhEQY91QfFm4phfYP4jc2TQ2opIFYdUIHkc+yrZwBhrgb/pPUUfemyqAoSbZcA==

"@patternfly/react-table@^5.0.0":
version "5.0.0"
resolved "https://registry.yarnpkg.com/@patternfly/react-table/-/react-table-5.0.0.tgz#2808f22d01818c31e6ddc69cc3a07c9381dc6d84"
integrity sha512-Q3MBo9+ZmBvLJzVHxmV9f/4qQAz5Si743zVLHRwjh+tjbn/DrcbxJdT8Uxa3NGKkpvszzgi/LPeXipJOHOELug==
"@patternfly/react-table@^5.1.1":
version "5.1.1"
resolved "https://registry.yarnpkg.com/@patternfly/react-table/-/react-table-5.1.1.tgz#a56471ef3c349ad67c7f2ce27ad4fa1775c247bb"
integrity sha512-9tAtHj16hemJ6YRBWIm2O+QRNoFWYQt8ZLQ1G0KBwpg2t2G2CbGsS2RG+BamO4IVE6IPo3Yoo39p4UCNRiGVpA==
dependencies:
"@patternfly/react-core" "^5.0.0"
"@patternfly/react-icons" "^5.0.0"
"@patternfly/react-styles" "^5.0.0"
"@patternfly/react-tokens" "^5.0.0"
"@patternfly/react-core" "^5.1.1"
"@patternfly/react-icons" "^5.1.1"
"@patternfly/react-styles" "^5.1.1"
"@patternfly/react-tokens" "^5.1.1"
lodash "^4.17.19"
tslib "^2.5.0"

"@patternfly/react-tokens@^5.0.0":
version "5.0.0"
resolved "https://registry.yarnpkg.com/@patternfly/react-tokens/-/react-tokens-5.0.0.tgz#8e2698d32d5353359e713312687a6b08ead0080b"
integrity sha512-to2CXIZ6WTuzBcjLZ+nXi5LhnYkSIDu3RBMRZwrplmECOoUWv87CC+2T0EVxtASRtpQfikjD2PDKMsif5i0BxQ==
"@patternfly/react-tokens@^5.1.1":
version "5.1.1"
resolved "https://registry.yarnpkg.com/@patternfly/react-tokens/-/react-tokens-5.1.1.tgz#098b70b4ed4d05217004395abc7395a46acc9abe"
integrity sha512-cHuNkzNA9IY9aDwfjSEkitQoVEvRhOJRKhH0yIRlRByEkbdoV9jJZ9xj20hNShE+bxmNuom+MCTQSkpkN1bV8A==

"@pkgjs/parseargs@^0.11.0":
version "0.11.0"
Expand Down Expand Up @@ -5744,12 +5744,12 @@ flush-write-stream@^1.0.0:
inherits "^2.0.3"
readable-stream "^2.3.6"

focus-trap@7.4.3:
version "7.4.3"
resolved "https://registry.yarnpkg.com/focus-trap/-/focus-trap-7.4.3.tgz#a3dae73d44df359eb92bbf37b18e173e813b16c5"
integrity sha512-BgSSbK4GPnS2VbtZ50VtOv1Sti6DIkj3+LkVjiWMNjLeAp1SH1UlLx3ULu/DCu4vq5R4/uvTm+zrvsMsuYmGLg==
focus-trap@7.5.2:
version "7.5.2"
resolved "https://registry.yarnpkg.com/focus-trap/-/focus-trap-7.5.2.tgz#e5ee678d10a18651f2591ffb66c949fb098d57cf"
integrity sha512-p6vGNNWLDGwJCiEjkSK6oERj/hEyI9ITsSwIUICBoKLlWiTWXJRfQibCwcoi50rTZdbi87qDtUlMCmQwsGSgPw==
dependencies:
tabbable "^6.1.2"
tabbable "^6.2.0"

[email protected]:
version "1.5.10"
Expand Down Expand Up @@ -10621,10 +10621,10 @@ symbol-tree@^3.2.4:
resolved "https://registry.yarnpkg.com/symbol-tree/-/symbol-tree-3.2.4.tgz#430637d248ba77e078883951fb9aa0eed7c63fa2"
integrity sha512-9QNk5KwDF+Bvz+PyObkmSYjI5ksVUYtjW7AU22r2NKcfLJcXp96hkDWU3+XndOsUb+AQ9QhfzfCT2O+CNWT5Tw==

tabbable@^6.1.2:
version "6.1.2"
resolved "https://registry.yarnpkg.com/tabbable/-/tabbable-6.1.2.tgz#b0d3ca81d582d48a80f71b267d1434b1469a3703"
integrity sha512-qCN98uP7i9z0fIS4amQ5zbGBOq+OSigYeGvPy7NDk8Y9yncqDZ9pRPgfsc2PJIVM9RrJj7GIfuRgmjoUU9zTHQ==
tabbable@^6.2.0:
version "6.2.0"
resolved "https://registry.yarnpkg.com/tabbable/-/tabbable-6.2.0.tgz#732fb62bc0175cfcec257330be187dcfba1f3b97"
integrity sha512-Cat63mxsVJlzYvN51JmVXIgNoUokrIaT2zLclCXjRd8boZ0004U4KCs/sToJ75C6sdlByWxpYnb5Boif1VSFew==

tapable@^2.0.0, tapable@^2.1.1, tapable@^2.2.0:
version "2.2.1"
Expand Down

0 comments on commit 81bbef9

Please sign in to comment.