Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: more storybook #379

Merged
merged 7 commits into from
Aug 4, 2021
Merged

ci: more storybook #379

merged 7 commits into from
Aug 4, 2021

Conversation

mcataford
Copy link
Collaborator

@mcataford mcataford commented Aug 4, 2021

Description

storybook-eol/storybook-deployer#77 doesn't seem to have a solution posted and has been open for a while. Trying a couple more things from that discussion thread.

EDIT: It appears that the solution is a bump in @storybook/storybook-deployer as well as some hack in how the token it passed.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have used ESLint & Prettier to follow the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcataford mcataford merged commit b63e09e into master Aug 4, 2021
@mcataford mcataford deleted the ci/more-storybook branch August 4, 2021 00:28
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

🎉 This PR is included in version 8.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
* ci: more attempts

* ci: reverse to iterate

* chore: bump storybook-deployer

* ci: no actor?

* ci: token name

* ci: token name

* revert: master deploys, nonmaster dryruns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant