CollectionView feedback - Eliezer Sant Ana #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@er7santana Thank you for your submission and feedback. Pull-to-refresh is currently planned in the spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Android
iOS
What went well?
It was very easy and smooth the implementation. The new layout options such as HorizontalList, GridList are amazing and are going to substitute lots of "extra work" that we need to do today.
What didn't go well?
Actually, the only tiny issue that I faced in Android platform was that I was using a Grid with 3 rows, 1 for an Image, and 2 for Labels.
Using ListView, I was able to set the rows heights as "Auto" for the labels and it worked as expected, but with CollectionView I had to specify the Height of the row with a real value, otherwise the rows with the Labels were not visible in Android devices, the first row with the image occupied all the ItemTemplate space.
How is the performance?
I didn't have any problems with performance. I think it's just fine.
Missing or Desired Things:
I think it would be interesting to have a PullToRefresh feature just like ListView.