Add anchorPoint to ViewMapAnnotation
#53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darronschall
force-pushed
the
anchor-point
branch
from
c169580 to
6377e32
Compare
This uses `anchorPoint` from `UIView` when available (iOS 16+), otherwise it relies on `MKAnnotationView` `centerOffset` and converts the `anchorPoint` percentages into pixel values.
After applying the frame fix in the previous commit, the annotations displayed on the map with a white background. This brings back the clear background they previously had.
`UnitPoint` - https://developer.apple.com/documentation/swiftui/unitpoint - is more SwiftUI-y than `CGPoint`, and will allow the anchorPoint to use the constants like `.center` and `.bottom`. Extract extensions to make it trivial to convert the `UnitPoint` to a `centerOffset` within a rect, and to convert back to a `CGPoint` for the `UIView` `anchorPoint` property.
The `#available(iOS 16)` wasn't preventing the `anchorPoint` from being set, but that is only available on `UIView`, not `NSView`. Ensuring `UIKit` is available fixes the error, and we fall back to `centerOffset` otherwise.
darronschall
force-pushed
the
anchor-point
branch
from
6377e32 to
2d8951c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This builds on #48, since I also needed those attributes to help control how my markers cluster. If #48 gets merged first, this PR will be slightly easier to review.
I originally tried just adding
anchorPointtoViewMapAnnotationand passing it through to theMKMapAnnotationView(usingUIView'sanchorPointif available, otherwise falling back oncenterOffset), but the anchor point wasn't applying correctly.I borrowed from @allenhumphreys PR #40 to get the frame and the anchor point to apply correctly. I wasn't sure if that PR was ever going to get merged; I took the minimum changes necessary to get anchor point working in hopes of getting this PR merged.
I also looked at ideas in #38, which seems somewhat related. This could potentially fix #14 as well; I've noticed that my pins have a much more consistent location now during zoom/pan and seem to be anchored properly in the correct location.
My first pass made anchorPoint a
CGPoint, but I decided it would be better to useUnitPointas that's more SwiftUI-y. I can change it back toCGPointif you prefer.FWIW, I'm using this branch successfully in an iOS app, and I have pin-style markers. Setting
anchorPoint: .bottom(the bottom middle of the marker) keeps the pins in the correct location as the user moves the map around in my app.