Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comment on operation mode #193

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Conversation

cdn-lnk
Copy link
Contributor

@cdn-lnk cdn-lnk commented Sep 21, 2023

Hi @anderssandstrom and @kivel,

Just a minor update on the iPOS config file.

"Velocity mode" could mislead to "Profile Velocity Mode" (3)
@@ -174,7 +174,7 @@ epicsEnvUnset(ECMC_CH_ID)
#############################################################
############# Settings:

#Set velocity mode (9)
#Set Cyclic Sync Velocity (CSV) mode (9)
ecmcConfigOrDie "Cfg.EcAddSdo(${ECMC_EC_SLAVE_NUM},0x6060,0x0,9,1)"
epicsThreadSleep(0.01)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anderssandstrom are those threadsleeps really needed or are they left over from development?

@kivel kivel merged commit 768edb7 into paulscherrerinstitute:master Oct 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants