Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phytron 52.200.5 #194

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cdn-lnk
Copy link
Contributor

@cdn-lnk cdn-lnk commented Sep 22, 2023

Hejsan @anderssandstrom , @kivel

Another motor from Phytron. =)
This one is an older model, it is not available on the manufacture website anymore, I am including an older manual for reference.

Cryo motoren Morskate.pdf

hopefully this time I won't have to fix all the headers, comments and values. 😅

@cdn-lnk
Copy link
Contributor Author

cdn-lnk commented Oct 9, 2023

Hi @kivel ,
sorry for taking so long to reply.

I agree, but I've got 2 question then.


First question

50% of 5 amps is still higher than the EL7037 max (1.5 A) limit.
Which of the following options would be better:

  1. 50% of 1.5A
  2. 1.5A
  3. Different values for EL7037 (1.5A or 750mA?) and EL704x (2.5A)

Second question

I noticed a few other motors may fall in a similar situation (IMO).

Per @anderssandstrom request I am writing a patch to use macros for the max current.
Since I am already on it, would you guys like me to add macros for the reduced current and change the default reduced current to 50% of the max current?

This way we would have consistent/predictable behavior for the motors but it may break backwards compatibility.


FYI: @javicereijo and @mac-kan

*** If the answer for the second question is yes, I will use the strategy chosen on question 1.

@kivel
Copy link
Collaborator

kivel commented Oct 11, 2023

As to Q1: Is it prudent to use the underpowered EL7037 for such a large motor in the first place? In this special case, I'd use whatever holding current you guys figured out works with the motor.
As to Q2: Somehow I fail to see the use case for a MACRO. If one needs to deliberately set the drive to a lower current. I prefer to do so with the explicit call to the EcAddSdo command. This makes the intention 100% clear in the startup.iocsh. As the MACRO still allows for this, I'm fine with a MACRO for the max current. It must have the nominal current as a default value though.
Same goes for the reduced current.

Annex: if there is a motion for fully customized motor configs with macros. Wouldn't it make more sense to create a generic config for 70x7 and 70x1 drives? One that has MACROs for everything?

@kivel
Copy link
Collaborator

kivel commented Oct 27, 2023

@cdn-lnk
Is there any progress in this PR? I'd rather handle the MACRO related tasks in a separate issue, than have it in a PR.

@cdn-lnk
Copy link
Contributor Author

cdn-lnk commented Nov 7, 2023

Hi @kivel ,

I will need some time before I can work on this.
Can we keep it on hold for a while?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants