Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed API inconsistency #8

Merged
merged 15 commits into from
Apr 2, 2024
Merged

Fixed API inconsistency #8

merged 15 commits into from
Apr 2, 2024

Commits on Mar 27, 2024

  1. moved get_dap_settings and get_detector_settings into ENDPOINTS_GET

    @NichtJens
    NichtJens committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    665f1f1 View commit details
    Browse the repository at this point in the history

  2. status -> message; state -> status

    @NichtJens
    NichtJens committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    da48351 View commit details
    Browse the repository at this point in the history

  3. consistent return dicts with status and message

    @NichtJens
    NichtJens committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f50603c View commit details
    Browse the repository at this point in the history

  4. removed useless/fake zeros from take pedestal return dict

    @NichtJens
    NichtJens committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c80dde7 View commit details
    Browse the repository at this point in the history

  5. also return the exception type; also log the traceback

    @NichtJens
    NichtJens committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3d0a6be View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. renamed status: failed -> error

    @NichtJens
    NichtJens committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    bc13429 View commit details
    Browse the repository at this point in the history

  2. turned status="pass" into "error"

    @NichtJens
    NichtJens committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    a809922 View commit details
    Browse the repository at this point in the history

  3. only return message if there is no extra info

    @NichtJens
    NichtJens committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    d0f415e View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. renamed get_running_detectors_list -> get_running_detectors

    @NichtJens
    NichtJens committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    3650764 View commit details
    Browse the repository at this point in the history

  2. renamed get_allowed_detectors_list -> get_allowed_detectors

    @NichtJens
    NichtJens committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2991697 View commit details
    Browse the repository at this point in the history

  3. renamed utility get_current_run_number -> get_run_number

    @NichtJens
    NichtJens committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2a09410 View commit details
    Browse the repository at this point in the history

  4. renamed get_last_run_number -> get_current_run_number

    @NichtJens
    NichtJens committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    7f89f83 View commit details
    Browse the repository at this point in the history

  5. renamed get_next_run_number -> advance_run_number

    @NichtJens
    NichtJens committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    795b94b View commit details
    Browse the repository at this point in the history

  6. moved advance_run_number from ENDPOINTS_GET to ENDPOINTS_POST

    @NichtJens
    NichtJens committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    acd7d62 View commit details
    Browse the repository at this point in the history

  7. individual messages for advance_run_number and get_run_number

    @NichtJens
    NichtJens committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9607df6 View commit details
    Browse the repository at this point in the history