Add a NativeImage component #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment preview ready! 🚀 You can view this deployment at: https://staging.pax.dev/281 |
samuelselleck
force-pushed
the
ss/gif-primitive
branch
from
00904f4 to
008e8e2
Compare
|
Deployment preview ready! 🚀 You can view this deployment at: https://staging.pax.dev/281 |
samuelselleck
force-pushed
the
ss/gif-primitive
branch
from
008e8e2 to
a0684c6
Compare
samuelselleck
force-pushed
the
ss/gif-primitive
branch
from
a0684c6 to
f1affd7
Compare
|
Deployment preview ready! 🚀 You can view this deployment at: https://staging.pax.dev/281 |
1 similar comment
|
Deployment preview ready! 🚀 You can view this deployment at: https://staging.pax.dev/281 |
|
Deployment preview ready! 🚀 You can view this deployment at: https://staging.pax.dev/281 |
zackbrown
approved these changes
Oct 1, 2024
| @@ -140,7 +144,9 @@ impl PaxChassisWeb { | |||
|
|
|||
| let width = window.inner_width().unwrap().as_f64().unwrap(); | |||
| let height = window.inner_height().unwrap().as_f64().unwrap(); | |||
| (width, height, os_info) | |||
| let start = Instant::now(); | |||
| let get_time = Box::new(move || start.elapsed().as_millis()); | |||
| @@ -57,6 +61,11 @@ impl NodeContext { | |||
| self.node_transform_and_bounds.as_transform().inverse() * p | |||
| } | |||
|
|
|||
| /// Get std::time::Instant::now() | |||
| pub fn ellapsed_time_millis(&self) -> u128 { | |||
There was a problem hiding this comment.
note spelling typo, should be elapsed, but we can clean this up later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a NativeImage primitive (img tags support gif by default).
Did look at pausing the gif in suspended mode but didn't find a straightforward solution - to come back to later (if important).