Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native UI: Textbox #85

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Native UI: Textbox #85

merged 2 commits into from
Jan 18, 2024

Conversation

samuelselleck
Copy link
Contributor

Adds a native textbox with a change handler @textbox_change and field value text (see playground example). No styling of any kind atm!

Copy link
Member

@warfaj warfaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. small question + nit


// Handle size_x and size_y
if (patch.size_x != null) {
textbox.style.width = patch.size_x - 1 + "px";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have the -1 here?

}

textboxDelete(id_chain: number[]) {
console.log("textbox deleted");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can clean this up now

@samuelselleck samuelselleck merged this pull request into dev Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants