[WIP] Replace HK2/Types/Parser/Scanner with Jandex and cache in the domain #7165
Conversation
lprimak
changed the title
| void index(DeploymentContext deploymentContext) throws IOException; | ||
| void reindex(DeploymentContext deploymentContext) throws IOException; | ||
| boolean isJakartaEEApplication(DeploymentContext deploymentContext) throws IOException; | ||
| Index getRootIndex(DeploymentContext deploymentContext); |
There was a problem hiding this comment.
You might want to avoid spreading the JBoss classes like i.e. Index around in the Payara codebase.
There was a problem hiding this comment.
Index is kinda the whole point of this PR.
The issue is that current annotation scanning framework is not made for CDI, is slow, and can't be cached.
Jandex is a small, separate project, has no dependencies, and is tailor made for CDI.
While it did come from JBoss, it's no longer embedded in that ecosystem and can be used unencumbered.
Any effort to isolate Index class will result in an unnecessary wrapper that would not add any value.
Do you have a specific suggestion? Am I missing something?
There was a problem hiding this comment.
It would result in a wrapper class. I agree. But I would call it a useful one. It allows to control and limit the interface towards payara code and allows to switch technology if needed/wanted.
There was a problem hiding this comment.
And you could have convenience methods useful for payaras interaction with the index.
There was a problem hiding this comment.
Let's see where this goes... I think it's only used in one place anyway
…I-enabled library JARs - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - read web-fragment.xml from EAR-libs - processing ear-lib manifest - de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - made some structures final (cleanup) - fixed ear and concurrent classloader leaks, including refactored reflection caching
…s=true is specified
lprimak
force-pushed
the
jandex-deploy
branch
from
a4d5251 to
543e287
Compare
lprimak
force-pushed
the
jandex-deploy
branch
from
543e287 to
75c6091
Compare
Deploy performance improvements
This is an experiment (for now)
Currently, it's not certain how much performance improvements are achieved by this PR.
In the next few weeks, I would like to do some testing on exactly how much performance gains are achieved.
I am hoping that the PR will achieve orders-of-magnitude performance increase.
My issue is that my computer is too fast to compare deploy performance currently,
and I would need to overcome that issue.
Feedback is appreciated
Thank you.
Current (very preliminary) results
Currently, performance is only slightly improved for cached runs,
but slightly degraded for first-time deployments.
This is probably due to not-yet-implemented parallel scanning of dependencies.
Fixes #7079
Important info
This PR depends on #7032 and #7097 until that gets merged.