Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-10615 Fix deployment bugs discovered while implementing EAR enhancements #7212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FISH-10615 Fix deployment bugs discovered while implementing EAR enhancements #7212

wants to merge 1 commit into from

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Feb 24, 2025 •
edited
Loading

Description

While working on EAR enhancements, I ran into a few bugs. These are fixed by this PR:

  • EAR CDI deployment module is too sensitive when there are missing components,
    leading to deployment failures on artifacts that should succeed.
  • BDA Context not being initialized in EAR under certain circumstances
  • null key discovered in bundleToBeanDeploymentArchive.put() method
  • Converted currentDeploymentContext from ThreadLocal<Deque> to ThreadLocal as Deque was unnecessary and causing bugs
  • Properly destroying deployment class loader

Fixes #7201
Fixes #7214
Fixes #7215

@Pandrex247 Pandrex247 changed the title Fix deployment bugs discovered while implementing EAR enhancements FISH-10615 Fix deployment bugs discovered while implementing EAR enhancements Feb 24, 2025
@lprimak lprimak marked this pull request as draft February 24, 2025 23:52
@lprimak lprimak mentioned this pull request Feb 25, 2025
Open
@lprimak
Copy link
Contributor Author

lprimak commented Feb 26, 2025 •
edited
Loading

MP-TCK CDIPropertyNameMatchingTest is failing

@lprimak lprimak mentioned this pull request Feb 26, 2025
Closed
@lprimak lprimak force-pushed the fix-deployment-bugs branch from 8701480 to 39f8f2e Compare February 28, 2025 19:58
@lprimak lprimak marked this pull request as ready for review February 28, 2025 19:59
@lprimak
Copy link
Contributor Author

lprimak commented Feb 28, 2025

Ready to go.

@lprimak
bugfix: EAR deployment bugs found
ca72244 
- fixed current deployment context - made it a regular thread local, not queue
- only add CDI bundles that are not UNKNOWN
- disable injection on EAR-root context (wrong context mode)
- actually destroy deployment ClassLoader shareableTemp correctly
@lprimak lprimak force-pushed the fix-deployment-bugs branch from fba4f2e to ca72244 Compare February 28, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@lprimak