Fix transfer refund fee to treasury if fee is greater than zero #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnahProsperity
added
bug
chibie
requested changes
Sep 16, 2024
| @@ -203,8 +203,10 @@ contract Gateway is IGateway, GatewaySettingManager, PausableUpgradeable { | |||
| require(!order[_orderId].isRefunded, 'OrderRefunded'); | |||
| require(order[_orderId].protocolFee >= _fee, 'FeeExceedsProtocolFee'); | |||
|
|
|||
| // transfer refund fee to the treasury | |||
| IERC20(order[_orderId].token).transfer(treasuryAddress, _fee); | |||
| if (_fee > 0) { | |||
There was a problem hiding this comment.
we should use _fee != 0
it's cheaper in gas costs
There was a problem hiding this comment.
I kindly disagree with this sir.
chibie
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the issue with transferring 0 amoutn to treasury address when fee is 0
closes #43