Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add withdraw function to Gateway #51

Merged
merged 5 commits into from
Oct 14, 2024
Merged

feat: add withdraw function to Gateway #51

merged 5 commits into from
Oct 14, 2024

Conversation

OnahProsperity
Copy link
Collaborator

This pull request adds a new function called withdraw to the Gateway contract. The function allows a provider to withdraw an asset from the Gateway. The function requires a valid signature from the provider and checks if the provider has enough balance. If the conditions are met, the function transfers the specified amount of the asset to the recipient address and emits a Withdraw event. The pull request also includes tests for the new functionality.

@OnahProsperity OnahProsperity self-assigned this Sep 29, 2024
@OnahProsperity OnahProsperity added enhancement New feature or request deployment Deployment task labels Sep 29, 2024
Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tiny typo fix

contracts/Gateway.sol Outdated Show resolved Hide resolved
@chibie chibie force-pushed the provider_withdraw branch from 07ee50b to d369397 Compare October 14, 2024 14:41
@chibie chibie merged commit f1b5af1 into v1 Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Deployment task enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants