Zero transfer check during refund #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnahProsperity
added
bug
chibie
requested changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This pull request includes several updates to address changes, build information, and contract implementation. The most significant changes involve updating the addresses and build information for various contracts and ensuring consistency across the project files.
Updates to addresses and build information:
.openzeppelin/base.json: Added a new address and updated the layout with storage details for various contracts.README.md: Updated the Gateway Implementation address.scripts/config.ts: AddedGATEWAY_IMPLEMENTATIONaddress for network 8453.scripts/forceImport.ts: Updated the existing contract address.Updates to build information:
.dbg.jsonfiles to point to the new build-info file:artifacts/@openzeppelin/contracts-upgradeable/access/Ownable2StepUpgradeable.sol/Ownable2StepUpgradeable.dbg.jsonartifacts/@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol/OwnableUpgradeable.dbg.jsonartifacts/@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol/Initializable.dbg.jsonartifacts/@openzeppelin/contracts-upgradeable/security/PausableUpgradeable.sol/PausableUpgradeable.dbg.jsonartifacts/@openzeppelin/contracts-upgradeable/utils/AddressUpgradeable.sol/AddressUpgradeable.dbg.jsonartifacts/@openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol/ContextUpgradeable.dbg.jsonartifacts/@openzeppelin/contracts/token/ERC20/ERC20.sol/ERC20.dbg.jsonartifacts/@openzeppelin/contracts/token/ERC20/IERC20.sol/IERC20.dbg.jsonartifacts/@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol/IERC20Metadata.dbg.jsonartifacts/@openzeppelin/contracts/utils/Context.sol/Context.dbg.jsonartifacts/contracts/Gateway.sol/Gateway.dbg.jsonartifacts/contracts/GatewaySettingManager.sol/GatewaySettingManager.dbg.jsonartifacts/contracts/interfaces/IGateway.sol/IGateway.dbg.jsonartifacts/contracts/mocks/MockUSDC.sol/MockUSDT.dbg.jsonContract logic update:
contracts/Gateway.sol: Modified the logic to transfer the refund fee to the treasury if the fee is greater than 0.closes #43