fix(db-mongodb): incorrect join aggregation order causes perf issues, remove mongoose-aggregate-paginate-v2 #10936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove mongoose-aggregate-paginate-v2
r1tsuu
force-pushed
the
fix/incorrect-order-of-aggreagation
branch
from
f37d314 to
2f75573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10165 (reply in thread)
As described in the discussion, we have an incorrect order of aggregation pipeline when using aggregations with the join field. We must use
$sort,$skip,$limitbefore the$lookupor otherwise mongodb scans all the docs, applies$lookupfor them and only after applies$limit,$skip.Replaces
mongoose-aggregate-paginate-v2with a customaggregatePaginatebecause we need a custom solution here. This was considered in #9594 but it was reverted as for now.