chore(richtext-lexical): improve types of UploadData #10982
+46
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
requested review from
denolfe,
jmikrut and
DanRibbens
as code owners
GermanJablo
commented
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step closer to being able to remove
noUncheckedIndexedAccessinpackages/richtext-lexical/tsconfig.json.I'm introducing UploadData_P4 which is a more precise version of UploadData. I'm doing it as a different type because there's a chance it'll be a breaking change for some users.
UploadData is used in many places, but I'm currently replacing it only in
packages/richtext-lexical/src/exports/react/components/RichText/converter/converters/upload.tsx, because in the other files it's too rooted to other types like UploadNode.