Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add idType to sqlite args #8956

Closed
wants to merge 1 commit into from

Conversation

rilrom
Copy link
Contributor

@rilrom rilrom commented Oct 30, 2024

Resolves #8848.

idType is missing from the sqlite documentation, which can cause confusion when users want to use strings for the id column. This change moves it in parity with the postgres documentation.

It might be worth exploring how to make this documentation more explicit; serial and uuid don't immediately convey string or number formatting.

Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to support uuid I need to enable the int tests to run in CI with this configuration.

Good work, we can take it from here.

Copy link
Contributor

This PR is stale due to lack of activity.

To keep the PR open, please indicate that it is still relevant in a comment below.

@github-actions github-actions bot added the stale label Dec 11, 2024
@r1tsuu
Copy link
Member

r1tsuu commented Dec 17, 2024

I continued this here #10016 as it wasn't enough to just pass 'uuid' through.

@r1tsuu r1tsuu closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to edit existing documents with custom ids as of beta 114
3 participants