-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set data-js-sdk-library default value #465
Merged
+10
−1
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dcb41d6
Add dataJsSdkLibrary script attribute
nbierdeman b92af85
Set data-js-sdk-library to paypal-js when not react-paypal-js
nbierdeman 16eda8f
Remove dataJsSdkLibrary from PayPalScriptDataAttributes
nbierdeman 01cb0bc
Skip existing data-js-sdk-library validation
nbierdeman 10f881b
Move data-js-sdk-library logic to loadCustomScript
nbierdeman d4e18b4
Add data-js-sdk-library test
nbierdeman 99822f5
Add changeset
nbierdeman 414b8c0
Fix load cached script tests
nbierdeman 9d90088
Set default data-js-sdk-library value in loadScript
nbierdeman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@paypal/paypal-js": patch | ||
--- | ||
|
||
Set default data-js-sdk-library value |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,6 +64,10 @@ export function loadCustomScript( | |
|
||
const { url, attributes } = options; | ||
|
||
if (attributes && !attributes["data-js-sdk-library"]) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
attributes["data-js-sdk-library"] = "paypal-js"; | ||
} | ||
|
||
if (typeof url !== "string" || url.length === 0) { | ||
throw new Error("Invalid url."); | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This smells funky, because
dataJsSdkLibrary
is not a required script option, but if we don't add it here, the "load cached script" tests fail.