chore: resolve 1.78.0 clippy warnings

README.md

@@ -41,7 +41,7 @@ Currently, the following functionality is defined entirely by text or json files
 - **spawns** - *.json* - Spawn locations of monsters. There should be one spawn file per map.
 
 ## Building from source
-1. Install latest version of [rust](https://www.rust-lang.org/) (most recently confirmed working `1.77.0`)
+1. Install latest version of [rust](https://www.rust-lang.org/) (most recently confirmed working `1.78.0`)
 2. Download this repository
 3. Run `cargo build` in the repository root directory
 4. Copy `assets` directory into `target/debug` directory

rustyhack_server/src/game/ecs/queries/change_map.rs

@@ -27,7 +27,7 @@ pub(crate) fn change_map_request(
                 if position_message.position.pos_x == exit.x
                     && position_message.position.pos_y == exit.y
                 {
-                    player_position.current_map = exit.new_map.clone();
+                    player_position.current_map.clone_from(&exit.new_map);
                     player_position.pos_x = exit.new_x;
                     player_position.pos_y = exit.new_y;
                     player_position.velocity_x = 0;

rustyhack_server/src/game/ecs/queries/player_joined.rs

@@ -26,7 +26,7 @@ pub(crate) fn join_player(
     for (player_details, display_details, position, stats, inventory) in query.iter_mut(world) {
         if player_details.player_name == name && !player_details.currently_online {
             player_details.currently_online = true;
-            player_details.client_addr = client_addr.clone();
+            player_details.client_addr.clone_from(&client_addr);
             display_details.collidable = true;
             display_details.visible = true;
             info!(

rustyhack_server/src/game/ecs/queries/player_left.rs

@@ -21,7 +21,7 @@ pub(crate) fn set_player_logged_out(
             && player_details.player_name == originating_player_name
         {
             logged_out_id = player_details.id;
-            logged_out_map = position.current_map.clone();
+            logged_out_map.clone_from(&position.current_map);
             display_details.visible = false;
             display_details.collidable = false;
             player_details.currently_online = false;
@@ -44,7 +44,7 @@ pub(crate) fn set_player_disconnected(world: &mut World, address: &str) -> (Uuid
     for (player_details, display_details, position) in query.iter_mut(world) {
         if player_details.client_addr == address {
             logged_out_id = player_details.id;
-            logged_out_map = position.current_map.clone();
+            logged_out_map.clone_from(&position.current_map);
             display_details.visible = false;
             display_details.collidable = false;
             player_details.currently_online = false;