Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import collections.abc if missing from base class #353

Closed
wants to merge 1 commit into from
Closed

Import collections.abc if missing from base class #353

wants to merge 1 commit into from

Conversation

whudson
Copy link

@whudson whudson commented Apr 14, 2022

This PR addresses #352.

Try to access the abstract base classes on the collections object, and if we cannot they need to be accessed from collections.abc.

@timcoote
Copy link

A thought on this: since python 3.3, the canonical way to get at the classes Iterable and Sequence has been via collections.abc. From the pypi page, I think that the first Python3 supported version for gmaps is 3.5. So would it make sense to make the code more idomatic, rather than aliasing collections.abc as collections to reduce future confusion?

If earlier versions of Python 3 are intended to be supported, then should there be a test to warn about unnecessary code for later versions?

@whudson whudson closed this Apr 6, 2023
@whudson whudson deleted the collections-abcs branch April 6, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants