Merge pull request #349 from tangkong/bug_args_simplenamespace

FIX: make tst_pim_2 loadable, types.SimpleNamespace does not take positional args
pcdshub · Oct 15, 2024 · 886aa25 · 886aa25
2 parents 0f61759 + 08b7f1a
commit 886aa25
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/docs/source/upcoming_release_notes/349-bug_args_simplenamespace.rst b/docs/source/upcoming_release_notes/349-bug_args_simplenamespace.rst
@@ -0,0 +1,22 @@
+349 bug_args_simplenamespace
+############################
+
+API Breaks
+----------
+- N/A
+
+Features
+--------
+- N/A
+
+Bugfixes
+--------
+- Fixes issue in test suite, making tst_base_pim2 a loadable SimpleNamespacce
+
+Maintenance
+-----------
+- N/A
+
+Contributors
+------------
+- tangkong
diff --git a/happi/tests/conftest.py b/happi/tests/conftest.py
@@ -429,9 +429,6 @@ def db(tmp_path):
     "tst_base_pim2": {
         "_id": "tst_base_pim2",
         "active": true,
-        "args": [
-            "{{prefix}}"
-        ],
         "beamline": "TST",
         "creation": "Wed Jan 30 09:46:00 2019",
         "device_class": "types.SimpleNamespace",

diff --git a/happi/tests/test_cli.py b/happi/tests/test_cli.py
@@ -269,9 +269,7 @@ def test_search_json(runner: CliRunner, happi_cfg: str):
   {
     "name": "tst_base_pim2",
     "device_class": "types.SimpleNamespace",
-    "args": [
-      "{{prefix}}"
-    ],
+    "args": [],
     "kwargs": {
       "name": "{{name}}"
     },