Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV/MNT: migrate to GitHub Actions and pyproject.toml [LCLSPC-603] #358

Merged
merged 28 commits into from
Feb 23, 2023

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Feb 22, 2023

Description

  • Upgrading by way of https://github.com/pcdshub/pcds-python-migration-tools
  • hutch-python no longer uses Travis CI and has migrated to GitHub Actions for continuous integration, testing, and documentation deployment.
  • hutch-python has been migrated to use setuptools-scm, replacing versioneer, as its version-string management tool of choice.
  • hutch-python has been migrated to use the modern pyproject.toml, replacing setup.py and related files.
  • Older language features and syntax found in the repository have been updated to Python 3.9+ standards by way of pyupgrade.
  • Sphinx 6.0 is now supported for documentation building. docs-versions-menu replaces doctr-versions-menu and doctr usage for documentation deployment on GitHub Actions. The deployment key is now no longer required.
  • pyupgrade was used to update annotations.
  • pycln was used to clean up imports

Motivation and Context

  • Migrating because we want to migrate our projects from Travis CI for one

How Has This Been Tested?

  • GitHub Actions

Where Has This Been Documented?

This PR and Jira LCLSPC-603

Performed by pcds-migration-tools DeleteFiles
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools AddFileFromTemplate
Performed by pcds-migration-tools GitHubActionsMigration
Performed by pcds-migration-tools UpdateSphinx
Performed by pcds-migration-tools RunPyupgrade
Performed by pcds-migration-tools PyprojectTomlMigration
Performed by pcds-migration-tools SetuptoolsScmMigration
Performed by pcds-migration-tools UpdateCondaRecipe
Performed by pcds-migration-tools RunPycln
Performed by pcds-migration-tools PrecommitAutoupdate
@klauer
Copy link
Contributor Author

klauer commented Feb 22, 2023

One test consistently failing: FAILED hutch_python/tests/test_tstpython.py::test_tstpython_ipython
Need to look into details...

Some other weird output in the log, but discussed in side channels it's probably intentional-ish

@tangkong
Copy link
Contributor

This might be the same test that's been failing? #354 (yep https://app.travis-ci.com/github/pcdshub/hutch-python/jobs/588574480#L1011)

This also probably closes #335 ?

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix that test in a differently scoped PR

.coveragerc Outdated Show resolved Hide resolved
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 All of these migration PRs are starting to blur together

@klauer
Copy link
Contributor Author

klauer commented Feb 23, 2023

(Merging and bypassing branch restrictions; reviewers indicated that IPython-related bug should be solved in a separate PR)

@klauer klauer merged commit a393118 into pcdshub:master Feb 23, 2023
@klauer klauer deleted the mnt_migrate_gha branch February 23, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants