Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hard code SL GAP low limit #124

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

patoppermann
Copy link
Contributor

Description

Hard code the Exit Slit lower limit to true.

Motivation and Context

The limit switch is not installed in the right place, so we will remove it from the code or set it to always True via hard core.

How Has This Been Tested?

input via online change

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

Copy link

@NSLentz NSLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Later on, we can try to convince Georgie to bring this back with the open loop approach or perhaps even better we can get the switch repositioned.

@patoppermann patoppermann merged commit b0ba2e1 into pcdshub:master May 28, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants