MR1K1, MR1K2, SP1K1 State Movers With PMPS #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
Sep 25, 2024
| @@ -245,7 +261,36 @@ fM1K2_Flow_1_val := fM1K2_Flow_1.fReal; | |||
| fM1K2_Flow_2(iTermBits:=15, fTermMax:=5.0427, fTermMin:=0.050472); | |||
| fM1K2_Flow_2_val := fM1K2_Flow_2.fReal; | |||
| fM1K2_Press_1(iTermBits:=15, fTermMax:=4.0, fTermMin:=0); | |||
| fM1K2_Press_1_val := fM1K2_Press_1.fReal;]]></ST> | |||
| fM1K2_Press_1_val := fM1K2_Press_1.fReal; | |||
There was a problem hiding this comment.
Possibly a bugfix you did here that's missing from the PR description
There was a problem hiding this comment.
This used to be the end of the program implementation on line 248. I think this is just a the diff of the XML end tag getting moved.
There was a problem hiding this comment.
You're right, I misread the diff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement state movers with PMPS for
lcls-twincat-motionto 4.1.1 needed changes for TcBSD PLC pmps file transfer.Motivation and Context
How Has This Been Tested?
caoutWhere Has This Been Documented?
https://jira.slac.stanford.edu/browse/ECS-936
related device update: pcdshub/pcdsdevices#1290
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)