QADC Update: Background Subtraction, CFD Edge Detection #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for the QADC PR to get reviewed, merged, and released prior to marking this ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the new PVs that have been recently added to the QADC IOC to the QADC python class. Also removes duplicate code for the qadc in the pcdsdevices codebase.
Motivation and Context
Helps support Jira ticket ECS-5843.
Closes #1190
How Has This Been Tested?
Tested interactively with a QADC running the new IOC in TMO.
Where Has This Been Documented?
This PR.
Screenshots:
Typhos screen of OUT0:
Control Screen:
Pre-merge checklist