Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LengthOfString Issue #73 #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sambhavkaul
Copy link

Created a function LengthOfString , issue #73

@sarthak247
Copy link
Contributor

This issue wasn't assigned to you, but you still submitted a PR. Such PR are generally considered as invalid.

programs/C/length_string.c Outdated Show resolved Hide resolved
programs/C/length_string.c Outdated Show resolved Hide resolved
programs/C/length_string.c Outdated Show resolved Hide resolved
@sambhavkaul
Copy link
Author

I thought by asking for taking this issue means assigning yourself, sorry for that. I have updated the program as per the description please see to it.

@AkshayCHD
Copy link
Contributor

@1Oozaru1 please change the commit message and make every thing in present tense, no past tense required in commit messages, use git amend for the purpose

@sambhavkaul
Copy link
Author

@AkshayCHD Done

programs/C/length_string.c Outdated Show resolved Hide resolved
programs/C/length_string.c Outdated Show resolved Hide resolved
programs/C/length_string.c Outdated Show resolved Hide resolved
programs/C/length_string.c Outdated Show resolved Hide resolved
programs/C/length_string.c Outdated Show resolved Hide resolved
programs/C/length_string.c Outdated Show resolved Hide resolved
programs/C/length_string.c Outdated Show resolved Hide resolved
programs/C/length_string.c Show resolved Hide resolved
@AkshayCHD
Copy link
Contributor

@1Oozaru1 Also try to make one commit out of the three (you can use git reset --soft for that)

@sambhavkaul
Copy link
Author

@AkshayCHD Done Sir, Please see to it.

@sambhavkaul sambhavkaul changed the title Created LengthOfString Issue #73 Create LengthOfString Issue #73 Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants