Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image for jumbotron #103

Closed
wants to merge 0 commits into from

Conversation

ankurbhatia24
Copy link

Fixes issue #77

Changes: The background of the jumbotron is changed.
The title is brought in the center of the jumbotron.

@ankurbhatia24
Copy link
Author

Please review!

@sagar-kalra
Copy link
Collaborator

Can you please provide the screenshot of the page? @loveiswar

@ankurbhatia24
Copy link
Author

screenshot-2017-10-7 screenshot

@sagar-kalra
Copy link
Collaborator

@gurpreetsingh00885 @divyam3897 Please review this change. Is this what you were looking for?

@elskhn
Copy link
Contributor

elskhn commented Oct 7, 2017

@loveiswar I think that you haven't started the server in your screenshot, which is why those Django template blocks are showing up. You have to test your commits as well. See the README.md file for more details on how to do this.

@ankurbhatia24
Copy link
Author

@Abdullah-k
I think that's not the demand of the issue!

@elskhn
Copy link
Contributor

elskhn commented Oct 7, 2017

@loveiswar
I understand. You sent me an e-mail asking about this. Please check your inbox, I replied to you explaining this stuff 😄

@gurpreetsingh00885 gurpreetsingh00885 temporarily deployed to pclubuiet-pr-103 October 8, 2017 06:13 Inactive
Copy link
Contributor

@divyam3897 divyam3897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see no change on any of the pages. You just need to add an image to the jumbotron and not the whole page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants