Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed playlists video titles not updating #13

Merged
merged 5 commits into from
Jul 8, 2019
Merged

Fixed playlists video titles not updating #13

merged 5 commits into from
Jul 8, 2019

Conversation

Seneral
Copy link
Contributor

@Seneral Seneral commented Jan 13, 2019

Modified the radio and mix fix again, this time with proper include and exclude list as to not make an error again. Result is even neater than before.

@Seneral
Fixed playlists video titles not updating
a80f6de 
Modified the radio and mix fix again, this time with proper include and exclude list as to not make an error again. Result is even neater than before.
@Seneral
Added more to include list
ceebd9f 
no functional changes, just for completeness sake
@Seneral
Fixed edge-case errors
6d953fa 
Fixed invalid API request with over 50 IDs (instead splitting them up)
Fixed repeated API request on video IDs of private/deleted videos which won't have any data in the API response
Improved video element search in the DOM to first list by ID and then filter on way fewer elements than before
Improved video ID extraction from element to use regex
@Seneral
Copy link
Contributor Author

Seneral commented Mar 11, 2019

Another small reminder for a merge, a few more fixes have been added (not including the issues still present on this github, but other, more hidden errors)

@Seneral
Copy link
Contributor Author

Seneral commented Mar 11, 2019

Added support for timestamp links in video description (#15)
It is not perfect, for some reason clicking my linkified timestamps reloads the whole window, whereas with youtube's default timestamps it does not, despite being exactly the same HTML code.
There's probably some magic going on when youtube enters prepares the text (like setting these links on a watchlist, nothing that could be traced back the the HTML code...).
Also, I did NOT yet test timestamps including hours (1:11:11), but it should work just fine.

@Seneral
Copy link
Contributor Author

Seneral commented Apr 10, 2019

Any plans to accept and update? It's not a trivial update anymore with several fixes so it'd rather have it updated officially.

@pcouy
Copy link
Owner

pcouy commented Jul 2, 2019

Thank you for being invested in this project. The improvements you made look neat, but since I was satisfied with the (somewhat incomplete and buggy) previous version, I did not take the time to try it out. Please accept my apologies for not giving enough consideration to your hard work.

I will have some free time soon and will gladly merge this after I try it out and review the code. Do you still use it ? Does it still work smoothly ?

@Seneral
Copy link
Contributor Author

Seneral commented Jul 3, 2019 •
edited
Loading

Ya it's fine, can understand.
Seems so, although over the months I had one or two cases where the titles were mismatched. Considering how often I use YT this is a very low failure rate but can't claim it's 100% stable. Changes I made are definitely fixing the stuff they're supposed to fix, that I can assure.

Edit: Well, the livestream description duplication bug is still there, but it hasn't bothered me too much so far.

@pcouy pcouy merged commit b18383a into pcouy:master Jul 8, 2019
@pcouy pcouy mentioned this pull request Jul 13, 2019
Merged
pcouy added a commit that referenced this pull request Jul 13, 2019
@pcouy
Update AntiTranslate.user.js
3e8bb2f 
Change version number to fix issues for people who upgraded to 0.2 (#17 #18 #13)
Seneral pushed a commit to Seneral/YoutubeAutotranslateCanceler that referenced this pull request Sep 21, 2021
@pcouy
Merge pull request pcouy#13 from Seneral/master
053f76c 
Fixed playlists video titles not updating
Seneral pushed a commit to Seneral/YoutubeAutotranslateCanceler that referenced this pull request Sep 21, 2021
@pcouy
Update AntiTranslate.user.js
db030a6 
Change version number to fix issues for people who upgraded to 0.2 (pcouy#17 pcouy#18 pcouy#13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Seneral @pcouy