Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #800 #819

Merged
merged 9 commits into from
Dec 29, 2023
Merged

Fix #800 #819

merged 9 commits into from
Dec 29, 2023

Conversation

pettzilla1
Copy link
Contributor

@pettzilla1 pettzilla1 commented Oct 18, 2022

Pull request

Adds additional requirements to the CONTRIBUTING.md file.

Closes #800

How Has This Been Tested?

Using licensecheck

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

Updated to include guidelines for new packages
@KunalGehlot
Copy link
Contributor

Mentioning #800 to link the issue

@KunalGehlot
Copy link
Contributor

Did you check all the current requirements for any infringements? I would like to know how something like this can be done.

@pettzilla1
Copy link
Contributor Author

Hi @KunalGehlot , I checked the current requirements a while ago and there hasn't been an update since.
To do what is mentioned you have to look at what packages are required for the install of a package this is ether in the setup file or can be in a separate file they reference . if those packages are on github the licence tag should tell you there licence and the process again followed for their dependencies. pypi can also be used to get some of this information

@pettzilla1
Copy link
Contributor Author

@pietermarsman are you able to review and merge ?

@pettzilla1
Copy link
Contributor Author

@pietermarsman , do you have any issues with this , if not please could it be merged ?

@pietermarsman
Copy link
Member

I checked our current licenses with licensecheck and they are all compatible.

Ideally we want it in cicd, but I did not get that to work just yet. I've created an issue for that.

@pietermarsman pietermarsman added this pull request to the merge queue Dec 29, 2023
Merged via the queue into pdfminer:master with commit 17a3617 Dec 29, 2023
10 checks passed
@pietermarsman
Copy link
Member

Thanks @pettzilla1 for starting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up from pull request #744
3 participants